crush: clean up whitespace removal #7157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@songbaisen your comment is missing the related tracker ticket number? |
|
@tchaikov Thanks very much for your reply.Use the boost function is more simple.But in this file there is none boot function used.So for the consistency may be use STL is better.Just personal opinion。 |
|
for the record, i was suggesting "boost::trim_copy()",
strictly speaking, that compilation unit is using boost::spirit. and i see no harm to use boost here. |
Fixes: ceph#14302 Signed-off-by: songbaisen song.baisen@zte.com.cn
|
@tchaikov Yes,your idea is very good. I have test use boost::trim_copy() is more simple than stl string.Thanks a lot to you! |
liewegas
added a commit
that referenced
this pull request
Jan 13, 2016
crush: clean up whitespace removal Reviewed-by: Sage Weil <sage@redhat.com> Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crush:Remove all the before and after space in better way.
Fixes: #14302
Signed-off-by: songbaisen song.baisen@zte.com.cn