crush: add chooseleaf_stable tunable #6572
Conversation
|
@Sandy4999 I separated this out into separate patches to improve review, added tests, and made a few fixes to the feature bits. Please review! @dachary Would be great if you could take a look too. Thanks! |
ghost
self-assigned this
|
@liewegas LGTM, thank you for the help! |
liewegas
force-pushed
the
wip-crush-chooseleaf-stable
branch
from
38e6905
to
7ed1fcf
Compare
|
@Sandy4999 Oh right, yep.. repushed! |
liewegas
force-pushed
the
wip-crush-chooseleaf-stable
branch
from
7ed1fcf
to
3e1a10a
Compare
crushtool: error reading '/home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins/src/test/cli/crushtool/test-map-hammer-tunables.crushmap': can't open /home/jenkins/workspace/ceph/LABELS/ceph-centos-7-jenkins/src/test/cli/crushtool/test-map-hammer-tunables.crushmap: (2) No such file or directory |
liewegas
force-pushed
the
wip-crush-chooseleaf-stable
branch
from
3e1a10a
to
822c66e
Compare
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Add a tunable to fix the bug that chooseleaf may cause unnecessary pg migrations when some device fails. Signed-off-by: Sangdi Xu <xu.sangdi@h3c.com>
Signed-off-by: Sangdi Xu <xu.sangdi@h3c.com>
Signed-off-by: Sangdi Xu <xu.sangdi@h3c.com>
Signed-off-by: Sangdi Xu <xu.sangdi@h3c.com>
Set chooseleaf_stable = 1 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-crush-chooseleaf-stable
branch
from
822c66e
to
4589678
Compare
ghost
self-assigned this
|
@liewegas it would be good to have a unit test verifying the expected difference between stable == 0 & stable == 1. The change is enough :-) There should also be an associated ceph-qa-suite test to verify it behaves as expected during upgrades ? |
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-crush-chooseleaf-stable
branch
from
4589678
to
beacff5
Compare
|
@dachary that's what the jewel test mapping is supposed to show, although I just check it and I had made a mistake (chooseleaf_stable = 1 wasn't set in the jewel map). Fixing that now. |
|
We don't have a good strategy for testing that the feature bits are enforced during upgrades. :/ |
Reviewed-by: Loic Dachary <ldachary@redhat.com> |
crush: add chooseleaf_stable tunable Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
mentioned this pull request
No description provided.