common: new timekeeping common code, and Objecter conversion #5782
Conversation
adamemerson
force-pushed
the
wip-cxx11time
branch
3 times, most recently
from
504885f
to
cc75b69
Compare
|
@adamemerson could you remove the unrelated commits from your pull request? and you might want to add the "Signed-off-by" line for all your commts per https://github.com/ceph/ceph/blob/master/SubmittingPatches#L62 . |
adamemerson
force-pushed
the
wip-cxx11time
branch
from
cc75b69
to
745bb08
Compare
|
Sorry, I forgot to sign off on the top one. There aren't really any unrelated commits. You need the timer and the perfcounters and so forth to get OSDC to work. And I was asked to update one subsystem as a demonstration. |
|
@adamcrume i meant 1d96cb3, 12e0d2b and a461a7a. they are already in master. |
adamemerson
force-pushed
the
wip-cxx11time
branch
from
745bb08
to
ba219cd
Compare
|
All right, rebased on master and repushed. Github shows me six commits and they look to be the ones I want. |
adamemerson
force-pushed
the
wip-cxx11time
branch
from
ba219cd
to
4bcf7ef
Compare
adamemerson
force-pushed
the
wip-cxx11time
branch
from
4bcf7ef
to
bc340f3
Compare
| return time_point(seconds(ts.tv_sec) + nanoseconds(ts.tv_nsec)); | ||
| } | ||
|
|
||
| coarse_real_clock::time_point coarse_real_clock::now( |
There was a problem hiding this comment.
The coarse stuff seems to be unused?
There was a problem hiding this comment.
That is correct. It's currently unused. I added it because there was some thought it might be useful at some point. If, for example, we were logging elapsed time rather than basing logic on it and not querying a time for any other reason, a clock that was faster but lower resolution might be nice.
adamemerson
force-pushed
the
wip-cxx11time
branch
2 times, most recently
from
39bb5e1
to
de1039c
Compare
adamemerson
force-pushed
the
wip-cxx11time
branch
from
de1039c
to
3ffcb42
Compare
adamemerson
force-pushed
the
wip-cxx11time
branch
from
3ffcb42
to
75b3537
Compare
adamemerson
force-pushed
the
wip-cxx11time
branch
from
75b3537
to
8d68d43
Compare
|
UninitCondition ceph_timer.h 112 0x6D4AA3F /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19 0x58BD181 /lib/x86_64-linux-gnu/libpthread-2.19.so start_thread /build/buildd/eglibc-2.19/nptl pthread_create.c 312 0x75B347C /lib/x86_64-linux-gnu/libc-2.19.so clone /build/buildd/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64 clone.S 111 /a/sage-2015-12-16_21:46:23-rados-wip-sage-testing---basic-openstack/40211 |
adamemerson
force-pushed
the
wip-cxx11time
branch
from
8d68d43
to
4cfe46c
Compare
|
The newest push should fix this. We take the mutex in the constructor before starting the thread. |
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Since I'm making a pervasive change anyway, knock off end-of-line spaces and wrap overly long lines. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
liewegas
force-pushed
the
wip-cxx11time
branch
from
4cfe46c
to
ecf2beb
Compare
common: new timekeeping common code, and Objecter conversion Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
This branch is part of the modernization process helping to support later work. It adds support for the C++11 time (std::chrono) support and as an example changes one subsystem (in this case, OSDC) to use it as an example.