common: buffer/assert minor fixes #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likely an update missed from PR ceph#6686. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
The inline ms_fast_dispatch implementation calls assert, which puts asset.h in the interface. The fact that many Dispatcher descendants don't implement ms_fast_dispatch prevents making the method pure virtual--which suggests that maybe there is a need for a FastDispatcher interface that inherits Dispatcher and introduces ms_fast_dispatch and related? Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
|
lgtm. |
tchaikov
added a commit
that referenced
this pull request
Dec 22, 2015
Fixes some small issues Reviewed-by: Kefu Chai <kchai@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some small issues on master (12/20):
As noted in the commit message, possibly this suggests a need for a FastDispatcher interface, which could declare ms_fast_dispatch pure virtual.