common: assert: abort() rather than throw #6804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamemerson
force-pushed
the
putting-the-fail-in-assertion-failed
branch
from
b6f4312
to
5c07cd6
Compare
adamemerson
force-pushed
the
putting-the-fail-in-assertion-failed
branch
from
5c07cd6
to
e0491be
Compare
Assertion failure should be big. It should be catastrophic. It should make an impression! It should also not throw exceptions. This change does exactly that. More specifically it calls abort() so we don't throw out stack frames or otherwise mess up debugging. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
adamemerson
force-pushed
the
putting-the-fail-in-assertion-failed
branch
from
e0491be
to
f07e029
Compare
|
lgtm! |
liewegas
added a commit
that referenced
this pull request
Dec 18, 2015
common: assert: abort() rather than throw Reviewed-by: Sage Weil <sage@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assertion failure should be big. It should be catastrophic. It should
make an impression!
It should also not throw exceptions. This change does exactly that.
More specifically it calls abort() so we don't throw out stack frames or
otherwise mess up debugging.
Signed-off-by: Adam C. Emerson aemerson@redhat.com