cmake: made rocksdb an imported library #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimaredia
force-pushed
the
wip-cmake
branch
3 times, most recently
from
729cc67
to
3f4efe1
Compare
Systems with the minimum required version of CMake such as Ubuntu Trusty Tahr don't support INTERFACE_LINK_LIBRARIES, so rocksdb was made into an IMPORTED library. Added ROCKSDB_INCLUDE_DIR to simplify target_include_directories rocksdb. Signed-off-by: Ali Maredia <amaredia@redhat.com>
|
tested locally. compiles with cmake 2.8.12. |
tchaikov
added a commit
that referenced
this pull request
Jan 7, 2016
cmake: made rocksdb an imported library Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systems with the minimum required version of CMake
such as Ubuntu Trusty Tahr don't support
INTERFACE_LINK_LIBRARIES, so rocksdb was made into
an IMPORTED library.
Signed-off-by: Ali Maredia amaredia@redhat.com