ceph_test_libcephfs: tolerate duplicated entries in readdir #7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dirfrag get fragmented in the middle of readdir, the readdir result may contain duplicated entries. (but there shouldn't be any missing entries) Fixes: ceph#14377 Signed-off-by: Yan, Zheng <zyan@redhat.com>
|
@ukernel, please document what testing you performed to make sure this is good. (I assume you ran it against a vstart cluster or something? It looks good but don't want to pull it into an integration branch and have it break things because of a misplaced loop or something.) |
gregsfortytwo
added a commit
that referenced
this pull request
Jan 18, 2016
…-fs-testing #7246 Reviewed-by: Greg Farnum <gfarnum@redhat.com>
gregsfortytwo
added a commit
that referenced
this pull request
Jan 19, 2016
…-fs-testing #7246 Reviewed-by: Greg Farnum <gfarnum@redhat.com>
|
http://pulpito.ceph.com/gregf-2016-01-18_18:01:09-fs-greg-fs-testing-118-1---basic-mira/ See also http://tracker.ceph.com/issues/14271, a ticket to make this unnecessary. |
gregsfortytwo
added a commit
that referenced
this pull request
Jan 20, 2016
ceph_test_libcephfs: tolerate duplicated entries in readdir Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dirfrag get fragmented in the middle of readdir, the readdir
result may contain duplicated entries. (but there shouldn't be
any missing entries)
Fixes: #14377
Signed-off-by: Yan, Zheng zyan@redhat.com