Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph.in: avoid a broken pipe error when use ceph command #7212

Merged
merged 1 commit into from Jan 14, 2016

Conversation

charpty
Copy link
Contributor

@charpty charpty commented Jan 13, 2016

when use command like 'ceph report | less' and press q, the following error occurs:
Traceback (most recent call last):
File "./ceph", line 936, in
retval = main()
File "./ceph", line 922, in main
raw_stdout.write(outbuf)
IOError: [Errno 32] Broken pipe

http://tracker.ceph.com/issues/14354

Signed-off-by: Bo Cai cai.bo@h3c.com

@tchaikov
Copy link
Contributor

@caibo2014 yeah, one needs to be really quick to press the "q" to trigger this issue.

could you prefix the title of your commit message with "ceph.in: ". other than this, lgtm.

@charpty charpty changed the title avoid a broken pipe error when use ceph commmand ceph.in:avoid a broken pipe error when use ceph commmand Jan 13, 2016
@charpty
Copy link
Contributor Author

charpty commented Jan 13, 2016

@tchaikov updated

@tchaikov
Copy link
Contributor

@caibo2014 that was quick. but by "your commit message", i mean the commit message, but not the title of your pull request. you might need to run git commit --amend to address it.

@charpty charpty force-pushed the fix-cephin-pipe-error branch 2 times, most recently from 23f04c7 to 60ac328 Compare January 13, 2016 14:23
@charpty charpty changed the title ceph.in:avoid a broken pipe error when use ceph commmand ceph.in:avoid a broken pipe error when use ceph command Jan 13, 2016
@charpty
Copy link
Contributor Author

charpty commented Jan 13, 2016

@tchaikov
Thank you for reminding , I have updated the commit message.

@tchaikov
Copy link
Contributor

you could link the tracker ticket with your pr by putting following line right before your signed-off-by line:

Fixes: #14354

Fixes: ceph#14354
Signed-off-by: Bo Cai <cai.bo@h3c.com>
tchaikov added a commit that referenced this pull request Jan 14, 2016
ceph.in: avoid a broken pipe error when use ceph command

Reviewed-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov merged commit 4c4d929 into ceph:master Jan 14, 2016
@charpty
Copy link
Contributor Author

charpty commented Jan 14, 2016

@tchaikov updated.

@ghost ghost changed the title ceph.in:avoid a broken pipe error when use ceph command ceph.in: avoid a broken pipe error when use ceph command Feb 10, 2016
@ghost ghost added the core label Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants