Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-fuse: fix double free of args #7015

Merged
merged 1 commit into from Dec 23, 2015
Merged

ceph-fuse: fix double free of args #7015

merged 1 commit into from Dec 23, 2015

Conversation

chipitsine
Copy link
Contributor

Checking src/ceph_fuse.cc...
[src/ceph_fuse.cc:55]: (error) Memory pointed to by 'argv' is freed twice.
[src/ceph_fuse.cc:55]: (error) Deallocating a deallocated pointer: argv

@liewegas liewegas added cleanup cephfs Ceph File System labels Dec 22, 2015
@tchaikov
Copy link
Contributor

@chipitsine could you

  1. add a title with an appropriate prefix for your commit, like "ceph-fuse: fix double free of args" ? and put the details into the commit message.
  2. add a Signed-off-by line at the end of your commit message? see https://github.com/ceph/ceph/blob/master/SubmittingPatches#L61, and you can find more examples using git log src/ceph_fuse.cc

thanks.

@ceph-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@tchaikov
Copy link
Contributor

ok to test

Checking src/ceph_fuse.cc...
[src/ceph_fuse.cc:55]: (error) Memory pointed to by 'argv' is freed twice.
[src/ceph_fuse.cc:55]: (error) Deallocating a deallocated pointer: argv

Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
@chipitsine
Copy link
Contributor Author

I added both prefix and Signed-off-by

@ghost
Copy link

ghost commented Dec 22, 2015

@ceph-jenkins test this please

@ghost
Copy link

ghost commented Dec 23, 2015

test this please

1 similar comment
@alfredodeza
Copy link
Contributor

test this please

@tchaikov
Copy link
Contributor

the test failure is not relevant.

there are multiple errors like

2015-12-23 02:11:07.898463 7efd19bc8400 -1 accepter.accepter.bind unable to bind to 127.0.0.1:7101: (98) Address already in use

seems the monitor was not completely shutdown.

and i am looking at the

tests/test_all.py::TestCephDetectInit::test_debian FAILED

failure. it only happens with py3. and is reproducible locally. addressed by #7025

@tchaikov
Copy link
Contributor

lgtm. tested locally.

@ghost
Copy link

ghost commented Dec 23, 2015

@alfredodeza this jenkins failure is a false negative, probably due to a previously failed test.

tchaikov added a commit that referenced this pull request Dec 23, 2015
ceph-fuse: fix double free of args

Reviewed-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov merged commit e0833f2 into ceph:master Dec 23, 2015
@ghost ghost changed the title cppcheck complains on double free ceph-fuse: fix double free of args Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cephfs Ceph File System cleanup
Projects
None yet
5 participants