ceph-fuse: fix double decreasing the count to trim caps #7229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhi Zhang zhangz.david@outlook.com
|
looks good |
gregsfortytwo
added a commit
that referenced
this pull request
Jan 18, 2016
…hub.com/david-z/ceph into greg-fs-testing #7229 Reviewed-by: Yan, Zheng <zyan@redhat.com>
gregsfortytwo
added a commit
that referenced
this pull request
Jan 20, 2016
…e-pressure ceph-fuse: fix double decreasing the count to trim caps Reviewed-by: Yan, Zheng <zyan@redhat.com>
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ceph-fuse will recalculate current caps size for each loop, so it double decreases the loop counts. Hence at most time, ceph-fuse client only trims half of expected caps number. MDS often reports the warning of failing to respond to cache pressure.
Both master and hammer branch have this issue and this fix has been tested locally on both branches, so it can be backported to hammer.
Fixes: #14319
Signed-off-by: Zhi Zhang zhangz.david@outlook.com