ceph-disk: warn for prepare partitions with bad GUIDs #6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If ceph-disk is a given partition device argument for prepare, it leaves the GPT GUID as is and doesn't check whether the partition's existing GUID matches the expected value. Print a warning in such cases. Fixes: ceph#13943 Signed-off-by: David Disseldorp <ddiss@suse.de>
|
@ddiss could you please attach a link to the output of a successfull ceph-disk suite ? If you're not sure what I mean, I can explain more ;-) |
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Jan 4, 2016
…uuid ceph-disk: warn for prepare partitions with bad GUIDs Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If ceph-disk is a given partition device argument for prepare, it leaves
the GPT GUID as is and doesn't check whether the partition's existing
GUID matches the expected value. Print a warning in such cases.
Fixes: #13943
Signed-off-by: David Disseldorp ddiss@suse.de