ceph-detect-init: fix py3 test #7025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov the purpose of ceph-detect-init is to return the init system supported by Ceph for a given distribution. Even though jessie switched to systemd, I'm not sure we have tests that run and verify it works. I think we should keep it to sysvinit until we do. Otherwise people running jessie will suddenly have a mixture of systemd / sysvinit, if running an infernalis OSD and a jewel OSD. Unless there is something I'm not seeing, I think best to stick to sysvinit for jessie and plan a switch to systemd for the next debian version. This choice can be overritten by the sysadmin who deliberately want to switch to systemd. |
* in python3, None can not be compared with a str. and we should always set codename with a non empty str, so update TestCephDetectInit.test_debian so it always set a code name. and assert(codename and distroname) in choose_init(). Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-ceph-detect-init-py3
branch
from
5935914
to
80c770e
Compare
|
@dachary jessie related changes reverted. |
ghost
pushed a commit
that referenced
this pull request
Dec 23, 2015
ceph-detect-init: fix py3 test Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
HeyoQiang
pushed a commit
to HeyoQiang/ceph
that referenced
this pull request
Dec 29, 2015
ceph-detect-init: fix py3 test Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
added
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should always set codename with a non empty str, so update
TestCephDetectInit.test_debian so it always set a code name.
and assert(codename and distroname) in choose_init().
jessie, see
https://lists.debian.org/debian-ctte/2014/02/msg00405.html
Signed-off-by: Kefu Chai kchai@redhat.com