Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

[ng-aria] 'aria-disabled' attribute must not be set along with the 'disabled' #11830

Closed
damiengarbarino opened this issue May 7, 2015 · 1 comment

Comments

@damiengarbarino
Copy link

Hello,

When using angular aria, if the ng-disabled directive is set on an element and the condition is resolved to 'true', the aria-disabled element is also set automatically.

The W3C mentions that the aria-disabled attribute must not set if the disabled attribute (installed by ng-disabled) is already supported by the DOM element (ex: button).

See: http://www.w3.org/TR/aria-in-html/ look for "disabled"

Use the disabled attribute on any element that is allowed the disabled attribute in HTML5.
Only use the aria-disabled attribute for elements that are not allowed to have a disabled attribute in HTML5

Regards

@Narretz Narretz added this to the Backlog milestone May 8, 2015
@Narretz
Copy link
Contributor

Narretz commented May 8, 2015

We should only set aria-disabled "for elements that are not allowed to have a disabled attribute in HTML5". I assume the allowed elements are these: http://www.w3.org/TR/html5/disabled-elements.html

marcysutton added a commit to marcysutton/angular.js that referenced this issue Dec 9, 2015
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
marcysutton added a commit to marcysutton/angular.js that referenced this issue Jan 18, 2016
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
marcysutton added a commit to marcysutton/angular.js that referenced this issue Feb 2, 2016
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
marcysutton added a commit to marcysutton/angular.js that referenced this issue Feb 3, 2016
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
marcysutton added a commit to marcysutton/angular.js that referenced this issue Feb 3, 2016
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for `aria-multiline` on textareas has been removed. 

New support added for ngValue, ngChecked, and ngRequired, along with updated documentation.

Closes angular#13078
Closes angular#11374
Closes angular#11830
@gkalpak gkalpak closed this as completed in d06431e Feb 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants