This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Fix ngAnimateChildren + ngIf, add docs for the directive #13876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ngAnimateChildren would set the data on the element in an $observe listener. This is too late when the element is animated immediately after compilation, as happens with ngIf Closes angular#13865
| @@ -1492,6 +1492,22 @@ describe("animations", function() { | |||
| dealoc(element); | |||
| dealoc(child); | |||
| })); | |||
|
|
|||
| it('should respect the value if the directive is on an element with ngIf', | |||
| inject(function($animate, $rootScope, $rootElement, $compile) { | |||
|
A few minor comments, but LGTM otherwise. |
|
Thanks! Landed with your suggestions. |
Narretz
added a commit
that referenced
this pull request
Jan 28, 2016
Previously, ngAnimateChildren would set the data on the element in an $observe listener, which means the data was available after one digest happend. This is too late when the element is animated immediately after compilation, as happens with ngIf. Now the data is also set right in the linking function. Fixes #13865 Closes #13876
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.