This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(dateFilter, input): fix Date parsing in IE/Edge when timezone offset contains :
#13887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set contains `:` When `Date.parse`-ing a date string, IE and Edge don't recognize the timezone offset in the format `+HH:mm` (but only without the `:`). According to [the spec][1], the timezone offset should contain `:`. The [ISO 8601 Standard][2] allows both forms (with and without `:`). Although the `Date` implementation in JavaScript does not 100% follow the ISO 8601 Standard (it's just _based on it_), all other browsers seem to recognize both forms as well. [1]: http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.1.15 [2]: https://en.wikipedia.org/wiki/ISO_8601#Time_offsets_from_UTC Fixes angular#13880
|
LGTM |
gkalpak
added a commit
that referenced
this pull request
Jan 29, 2016
…set contains `:` When `Date.parse`-ing a date string, IE and Edge don't recognize the timezone offset in the format `+HH:mm` (but only without the `:`). According to [the spec][1], the timezone offset should contain `:`. The [ISO 8601 Standard][2] allows both forms (with and without `:`). Although the `Date` implementation in JavaScript does not 100% follow the ISO 8601 Standard (it's just _based on it_), all other browsers seem to recognize both forms as well. [1]: http://www.ecma-international.org/ecma-262/5.1/#sec-15.9.1.15 [2]: https://en.wikipedia.org/wiki/ISO_8601#Time_offsets_from_UTC Fixes #13880 Closes #13887
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Date.parse-ing a date string, IE and Edge don't recognize the timezone offset in the format+HH:mm(but only without the:). According to the spec, the timezone offset should contain:. The ISO 8601 Standard allows both forms (with and without:).Although the
Dateimplementation in JavaScript does not 100% follow the ISO 8601 Standard (it's just based on it), all other browsers seem to recognize both forms as well.Fixes #13880