This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1: don't suppress error output #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blixtra
force-pushed
the
ckuehl/stage1-dont-supress-errors
branch
from
ab0d1ad
to
a701f85
Compare
| @@ -140,7 +141,7 @@ func init() { | |||
| flag.StringVar(&podPid, "pid", "", "podPID") | |||
| flag.StringVar(&appName, "appname", "", "application to use") | |||
|
|
|||
| log = rktlog.New(os.Stderr, "kvm", false) | |||
| log, diag, _ = rktlog.NewLogSet("kvm", false) | |||
There was a problem hiding this comment.
TODO for later (added in #1131):
If rktlog.NewLogSet and exec.LookPath("ssh") are moved in main(), it will not need to call SetDebug() manually.
blixtra
force-pushed
the
ckuehl/stage1-dont-supress-errors
branch
from
b4475a1
to
9ac9bb8
Compare
|
Updated. Now with tests!!! 🎆 |
| ctx := testutils.NewRktRunCtx() | ||
| defer ctx.Cleanup() | ||
|
|
||
| // Prepare image |
There was a problem hiding this comment.
You don't need to prepare the image since you run rkt run directly below
blixtra
force-pushed
the
ckuehl/stage1-dont-supress-errors
branch
from
9ac9bb8
to
8689498
Compare
|
Update. |
|
LGTM on green |
|
LGTM as well |
alban
added a commit
that referenced
this pull request
Feb 4, 2016
stage1: don't suppress error output
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2038