This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Remove install command, replace with a script #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +29,7 @@ | |||
|
|
|||
| - The `--stage1-image` flag was removed. Scripts using it should be updated to use one of `--stage1-url`, `--stage1-path`, `--stage1-name`, `--stage1-hash` or `--stage1-from-dir` | |||
| - All uses of the deprecated `--insecure-skip-verify` flag should be replaced with the `--insecure-options` flag which allows user to selectively disable security features. | |||
| - The `rkt install` command was removed in favor of `scripts/setup-data-dir.sh` script. | |||
| else | ||
| mkdir --mode="${mode}" "${dir}" | ||
| fi | ||
| chgrp rkt "${dir}" |
There was a problem hiding this comment.
Do we need to test that the rkt group exists? I guess it is not necessary since we have set -e above. Does set -e persist across function calls?
There was a problem hiding this comment.
I don't think so, the whole point is to prepare the directory structure for rkt group, otherwise rkt will happily create required directories on first run.
set -e is global here.
krnowak
force-pushed
the
krnowak/remove-install
branch
from
9af22a0
to
caad3e2
Compare
|
Updated. |
| #!/usr/bin/env bash | ||
|
|
||
| # The script can take one parameter being a path to the rkt data | ||
| # directory. If none is passed, /var/lib/rkt is assumed. |
There was a problem hiding this comment.
keep in sync with dist/init/systemd/tmpfiles.d/rkt.conf?
The group package looks up given group name. It is moved to a separate package, so we don't have to include the github.com/coreos/rkt/common package it in github.com/coreos/rkt/tests/testutils. Importing it there ended up in errors when building the inspect binary, which is importing testutils. common package was importing indirectly some other package, which requires cgo, but cgo was disabled when building inspect.
krnowak
force-pushed
the
krnowak/remove-install
branch
from
caad3e2
to
0d30539
Compare
|
Updated, moving the group handling to separate package, so we won't error out because of trying to build a package that uses cgo with CGO_ENABLED=0. |
|
LGTM |
alban
added a commit
that referenced
this pull request
Feb 3, 2016
Remove install command, replace with a script
| @@ -0,0 +1,75 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Shouldn't this be in dist/ ?
alban
added a commit
to kinvolk/rkt
that referenced
this pull request
Feb 3, 2016
Move setup-data-dir.sh in dist/scripts/ so it will be in the release tarball. It was introduced by rkt#2101
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.