This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: Remove the deprecated --insecure-skip-verify flag #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about this change. Probably some documentation on the Internet mentions this flag and since it's just an alias, having it around doesn't hurt that much. On the other hand, it was deprecated a (relatively) long time ago and removing lines of code is always good. |
krnowak
force-pushed
the
krnowak/remove-deprecated-option
branch
from
75577b1
to
974992d
Compare
|
I am +1 on this, 1.0 should be our flag day, otherwise we are going to be stuck with this. |
Fair enough :) |
|
The patch looks good to me, if we decide to merge it for 1.0. |
|
This is completely reasonable and we don't want people starting with a 1.0 release and using deprecated flags out of the gate. |
krnowak
force-pushed
the
krnowak/remove-deprecated-option
branch
from
974992d
to
642233a
Compare
|
This passed before rebasing (it was only a conflict in CHANGELOG.md) so I'm merging it before the tests pass. |
iaguis
added a commit
that referenced
this pull request
Feb 2, 2016
rkt: Remove the deprecated --insecure-skip-verify flag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.