[#4017] Implement proper resource leak detection for CompositeByteBuf #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: CompositeByteBuf only implemented simple resource leak detection and how it was implemented was completly different to the way it was for ByteBuf. The other problem was that slice(), duplicate() and others would not return a resource leak enabled buffer. Modifications: - Proper implementation for all level of resource leak detection for CompositeByteBuf Result: Proper resource leak detection for CompositeByteBuf.
|
@Scottmitch @trustin @nmittler PTAL |
| @@ -50,6 +50,28 @@ protected static ByteBuf toLeakAwareBuffer(ByteBuf buf) { | |||
| return buf; | |||
| } | |||
|
|
|||
| protected static CompositeByteBuf toLeakAwareBuffer(CompositeByteBuf buf) { | |||
| ResourceLeak leak; | |||
| switch (ResourceLeakDetector.getLevel()) { | |||
There was a problem hiding this comment.
Can the level change? If not, would it be make sense to save off some sort of allocator for the leak aware buffers?
|
@normanmaurer +1 this was badly needed! :) Took a first pass ... just a few minor comments. Looks great! |
|
LGTM. Great job! |
|
@normanmaurer - lgtm ... great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
CompositeByteBuf only implemented simple resource leak detection and how it was implemented was completly different to the way it was for ByteBuf. The other problem was that slice(), duplicate() and others would not return a resource leak enabled buffer.
Modifications:
Result:
Proper resource leak detection for CompositeByteBuf.