Throw ReadOnlyBufferException if unsafe buffer is used and dst is direct #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trustin PTAL |
| public void testGetReadOnlyDirectDst() { | ||
| super.testGetReadOnlyDirectDst(); | ||
| } | ||
| @Test(expected = IndexOutOfBoundsException.class) |
There was a problem hiding this comment.
Please insert an empty line between methods.
|
@normanmaurer LGTM. Please cherry-pick once style comments are addressed. |
Motivation: We missed to check if the dst is ready only before using unsafe to copy data into it which lead to data-corruption. We need to ensure we respect ready only ByteBuffer. Modifications: - Correctly check if the dst is ready only before copy data into it in UnsafeByteBufUtil - Also make it work for buffers that are not direct and not have an array Result: No more data corruption possible if the dst buffer is readonly and unsafe buffer implementation is used.
normanmaurer
force-pushed
the
unsafe_readonly_dst_corruption
branch
from
673b47b
to
6d1eae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We missed to check if the dst is ready only before using unsafe to copy data into it which lead to data-corruption. We need to ensure we respect ready only ByteBuffer.
Modifications:
Result:
No more data corruption possible if the dst buffer is readonly and unsafe buffer implementation is used.