This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat($locale): Include original locale ID in $locale #13390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most systems use *IETF language tag* codes which are typically a combination of the ISO 639 language code and ISO 3166-1 country code with an underscore or hyphen delimiter. For example `en_US`, `en_AU`, etc. Whilst the `$locale.id` comes close, the lowercase format makes it impossible to transform to an IETF tag reliably. For example, it would be impossible to deduce `en_Dsrt_US` from `en-dsrt-us`. It would be very handy for communicating with external systems to be able to pass the IETF tag format, at least with the character casing intact.
|
@philBrown this doesn't actually work, since if you look further down the file the |
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
Jan 26, 2016
Most systems use *IETF language tag* codes which are typically a combination of the ISO 639 language code and ISO 3166-1 country code with an underscore or hyphen delimiter. For example `en_US`, `en_AU`, etc. Whilst the `$locale.id` comes close, the lowercase format makes it impossible to transform to an IETF tag reliably. For example, it would be impossible to deduce `en_Dsrt_US` from `en-dsrt-us`. Closes angular#13390
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
Jan 26, 2016
Closed
|
@gkalpak points out that your fix does indeed work, but since the code itself is weird, it will be better to fix it in the way I have done in the PR. |
petebacondarwin
added a commit
that referenced
this pull request
Jan 26, 2016
Most systems use *IETF language tag* codes which are typically a combination of the ISO 639 language code and ISO 3166-1 country code with an underscore or hyphen delimiter. For example `en_US`, `en_AU`, etc. Whilst the `$locale.id` comes close, the lowercase format makes it impossible to transform to an IETF tag reliably. For example, it would be impossible to deduce `en_Dsrt_US` from `en-dsrt-us`. Closes #13390
petebacondarwin
added a commit
that referenced
this pull request
Jan 26, 2016
petebacondarwin
added a commit
that referenced
this pull request
Jan 26, 2016
Most systems use *IETF language tag* codes which are typically a combination of the ISO 639 language code and ISO 3166-1 country code with an underscore or hyphen delimiter. For example `en_US`, `en_AU`, etc. Whilst the `$locale.id` comes close, the lowercase format makes it impossible to transform to an IETF tag reliably. For example, it would be impossible to deduce `en_Dsrt_US` from `en-dsrt-us`. Closes #13390
petebacondarwin
added a commit
that referenced
this pull request
Jan 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most systems use IETF language tag codes which are typically a combination of the ISO 639 language code and ISO 3166-1 country code with an underscore or hyphen delimiter. For example
en_US,en_AU, etc.Whilst the
$locale.idcomes close, the lowercase format makes it impossible to transform to an IETF tag reliably. For example, it would be impossible to deduceen_Dsrt_USfromen-dsrt-us.It would be very handy for communicating with external systems to be able to pass the IETF tag format, at least with the character casing intact.