This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): handle boolean attributes in @ bindings
#13769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be backported to 1.4 |
petebacondarwin
force-pushed
the
issue-13767
branch
2 times, most recently
from
b65e9f1
to
77a8807
Compare
|
Looks good. However, can you add a comment that explains why we have to do that? I'm not convinced it's angular that is modifying these boolean attributes. Isn't it the browser that converts the content of boolean attributes to "true"? |
|
Here is plunker that shows the problem is fixed by this PR: https://plnkr.co/edit/mk9BJODWJdYFhMpw3nGa?p=preview |
|
@Narretz here is the line where the boolean conversion happens I believe: https://github.com/angular/angular.js/blob/master/src/ng/directive/attrs.js#L339 |
|
You are right, thanks for the link. Can't hurt to put it in a little comment, though ;) |
|
Will do! |
Narretz
force-pushed
the
master
branch
2 times, most recently
from
70049ae
to
b77e14b
Compare
petebacondarwin
force-pushed
the
issue-13767
branch
from
77a8807
to
e6658cb
Compare
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
Jan 20, 2016
petebacondarwin
added a commit
that referenced
this pull request
Jan 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13767