This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): properly denormalize templates when only one of the start/end symbols is different #13848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art/end symbols is different
Previously, if either of the start/end interpolation symbols remained unchanged (i.e. `{{` or `}}`),
then directive templates would not be denormalized properly. Changing only one of the start/end
symbols (but not both) is an uncommon but legitimate usecase.
gkalpak
force-pushed
the
fix-compiler-denormalizeTemplate
branch
from
51ae443
to
66fd200
Compare
| @@ -3137,6 +3137,54 @@ describe('$compile', function() { | |||
| }); | |||
|
|
|||
|
|
|||
| it('should support custom start interpolation symbol, even when `endSymbol` doesn\'t change', | |||
There was a problem hiding this comment.
endSymbol is the default? (and below)
There was a problem hiding this comment.
What @gkalpak means is that these test that the functionality works even if you change only one of startSymbol and endSymbol
There was a problem hiding this comment.
I know, I just thought it was more explicit to state that the other symbol remains the default symbol. As is works for me though.
There was a problem hiding this comment.
I meant to change it as @Narretz suggested upon merge, but forgot to amend the commit before pushing 😞
|
LGTM with a small style suggestion |
|
LGTM |
gkalpak
added a commit
that referenced
this pull request
Jan 26, 2016
…art/end symbols is different
Previously, if either of the start/end interpolation symbols remained unchanged (i.e. `{{` or `}}`),
then directive templates would not be denormalized properly. Changing only one of the start/end
symbols (but not both) is an uncommon but legitimate usecase.
Closes #13848
|
Backported to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if either of the start/end interpolation symbols remained unchanged (i.e.
{{or}}), then directive templates would not be denormalized properly. Changing only one of the start/end symbols (but not both) is an uncommon but legitimate usecase.