Set idle timeouts for HTTP reads and writes in communications with a registry #19743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e registry Otherwise, some operations can get stuck indefinitely when the remote side is unresponsive. Fixes moby#12823 Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
aaronlehmann
force-pushed
the
http-idle-timeouts
branch
from
e305301
to
84b2162
Compare
|
cc @docker/distribution-maintainers |
|
LGTM |
|
LGTM |
1 similar comment
|
LGTM |
|
@aaronlehmann @dmcgowan is this for 1.10 ? |
|
@tiborvass: I'm not completely sure. This is a common user frustration that we wanted to fix in 1.10, and I would have submitted the PR much earlier if I had realized the problem still existed. I know we are getting late in the release cycle so I'm not sure whether it's too late. |
|
It's green so, let me merge |
thaJeztah
added a commit
that referenced
this pull request
Jan 26, 2016
Set idle timeouts for HTTP reads and writes in communications with a registry
|
@aaronlehmann @tiborvass adding more stability is a good thing; Is there any risk in this change? Guess that would be the deciding factor |
|
I think it's pretty low risk. |
|
Added impact/changelog as a notable bug fix for #12823 |
|
This was reverted in #19971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, some operations can get stuck indefinitely when the remote
side is unresponsive.
Fixes #12823