Make volume dangling filter return only used volumes with dangling=false.
#19671
Conversation
calavera
force-pushed
the
volume-dangling
branch
from
d4143da
to
ded6435
Compare
calavera
force-pushed
the
volume-dangling
branch
2 times, most recently
from
ca300c7
to
fa675d8
Compare
…alse`. Signed-off-by: David Calavera <david.calavera@gmail.com>
calavera
force-pushed
the
volume-dangling
branch
from
fa675d8
to
1431b62
Compare
|
So this changes it so you can't filter to list only the volumes that are in use? |
|
Does this make more sense @cpuguy83 ? |
|
+1 it, code is OK for me. |
|
Signed-off-by: David Calavera <david.calavera@gmail.com>
|
@albers can you take a look at the bash completion fix? |
| // Same as above, but explicitly disabling dangling | ||
| c.Assert(out, checker.Contains, "testnotinuse1\n", check.Commentf("expected volume 'testnotinuse1' in output")) | ||
| // Explicitly disabling dangling | ||
| c.Assert(out, check.Not(checker.Contains), "testnotinuse1\n", check.Commentf("expected volume 'testnotinuse1' in output")) |
There was a problem hiding this comment.
I guess what I don't quite understand is this change in case.... I suppose this false wasn't working before?
There was a problem hiding this comment.
before this change false meant all volumes, dangling and undangling.
|
LGTM |
|
LGTM |
|
All 💚 |
Make volume dangling filter return only used volumes with `dangling=false`.
|
@calavera bash completion is almost perfect. There is a trick that automatically appends the Thakns for taking care of the completion! |
docker volume ls --dangling=truereturns only volumes that are not used.docker volume ls --dangling=falsereturns only volumes that are used.docker volume lsreturns all the volumes.Copies the behavior of #19326.
Closes #19153.
/cc @cpuguy83, @HackToday
Signed-off-by: David Calavera david.calavera@gmail.com