This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
kvm: follow up to #1525 issue #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borqosky
force-pushed
the
wborkows/issue_1525
branch
from
b8c0c58
to
55be6a1
Compare
|
|
||
| func ensureKeysExistInPod(workDir string) error { | ||
| destRootfs := common.Stage1RootfsPath(workDir) | ||
| keyDirPath := filepath.Join(destRootfs, "/root", "/.ssh") |
There was a problem hiding this comment.
The slashes are not required here. "root", ".ssh" is enough.
|
One nit, otherwise looks fine and dandy. |
borqosky
force-pushed
the
wborkows/issue_1525
branch
from
55be6a1
to
fd479a5
Compare
|
|
||
| func ensureKeysExistInPod(workDir string) error { | ||
| destRootfs := common.Stage1RootfsPath(workDir) | ||
| fmt.Println(u.HomeDir) |
borqosky
force-pushed
the
wborkows/issue_1525
branch
from
fd479a5
to
f3048b5
Compare
ssh keys setup moved to stage1, from stage0. data directory (as requested by @krnowak) separated from stage0 rkt datadir. sshd port removed from configuration (inetd mode use only).
|
LFAD. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssh keys setup moved to stage1, from stage0. data directory
(as requested by @krnowak) separated from stage0 rkt datadir.
sshd port removed from configuration (inetd mode use only).