tests: skip userns tests when userns does not work #1947
Conversation
CentOS 7 pretends to support user namespaces but does not. See https://bugzilla.redhat.com/show_bug.cgi?id=1168776#c5 Skip rkt tests with user namespaces when the host cannot do user namespaces. rkt#1927
| @@ -25,6 +25,14 @@ import ( | |||
|
|
|||
| // TestNonRootReadInfo tests that non-root users that can do rkt list, rkt image list. | |||
| func TestNonRootReadInfo(t *testing.T) { | |||
| if !common.SupportsUserNS() { | |||
There was a problem hiding this comment.
Why do we need user namespaces for this?
There was a problem hiding this comment.
The test starts some pods: some with user namespaces and some without. Then it checks that rkt list works without being root.
I think the idea was to check that non-root access to /var/lib/rkt/pods/run/$UUID/stage1/rootfs/rkt/status/ works fine, even when the directory uid/gid is shifted by the user namespace. The test also tries with and without overlayfs because the "rkt/status" directory would be stored in a different location in case of overlay fs.
However, the test only runs rkt list and not rkt status. And I don't think rkt list needs to have access to the "rkt/status" directory...
|
This is not very nice but it improves the testing situation. LGTM |
tests: skip userns tests when userns does not work
CentOS 7 pretends to support user namespaces but does not. See
https://bugzilla.redhat.com/show_bug.cgi?id=1168776#c5
Skip rkt tests with user namespaces when the host cannot do user
namespaces.
#1927