rkt fly: add logic to insert environment value #1989
Conversation
|
|
||
| env := make([]string, len(envList)) | ||
| for _, e := range envList { | ||
| if _, exists := envList.Get(defaultEnv[0]); !exists { |
There was a problem hiding this comment.
The function Get accepts only the name of the environment variable and not its content.
type EnvironmentVariable struct {
Name string `json:"name"`
Value string `json:"value"`
}
But here, the argument is "PATH=/bin:/sbin:/usr/bin:/usr/local/bin".
|
This way You have possibility to insert some values into environ file in time of POD creation, but not in time of entering which is reading already build environ file. This second option is at least needed by any terminal using program ( |
alban
changed the title
il9ue
force-pushed
the
master
branch
2 times, most recently
from
e1e9022
to
ef7c89e
Compare
| env := []string{"PATH=/bin:/sbin:/usr/bin:/usr/local/bin"} | ||
| defaultEnvPath := []string{"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"} | ||
| envList := p.Manifest.Apps[0].App.Environment | ||
| env := make([]string, len(envList)) |
There was a problem hiding this comment.
The length seems to be len(envList)+len(defaultEnvPath)
|
@il9ue Thanks for the update! I added a couple of suggestions. |
il9ue
force-pushed
the
master
branch
2 times, most recently
from
90c7e04
to
687b21c
Compare
|
@alban Just updated and applied from suggestions and made changes! Thanks for specific feedback! |
| @@ -219,7 +219,15 @@ func stage1() int { | |||
| } | |||
|
|
|||
| // TODO: insert environment from manifest | |||
|
LGTM |
rkt fly: add logic to insert environment value
Insert environment value by checking related value in Manifest.
Please give any feedback.