This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Add insecure option http #1945
Merged
Add insecure option http #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add a CHANGELOG entry after the 0.15 release is done. |
| @@ -19,19 +19,21 @@ const ( | |||
| insecureImage = 1 << (iota - 1) | |||
| insecureTls | |||
There was a problem hiding this comment.
Damn, this should really be "insecureTLS" (c.f.)
There was a problem hiding this comment.
I was telling that to Alban on Friday. I'll do a quick PR for that.
|
LGTM |
With this the user will need to explicitly allow http connections. Previously, this was hard-code to be true. Fixes rkt#1945
blixtra
force-pushed
the
blixtra/add-insecure-option-http
branch
from
b10c006
to
d7d19d0
Compare
|
I've added the CHANGELOG and squashed the commits. |
This was referenced Jan 11, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code, tests, and documentation for a new "http"
--insecure-optionsflag.fixes #1836