Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added governor redmine module #18

Merged
merged 1 commit into from Dec 28, 2015
Merged

Added governor redmine module #18

merged 1 commit into from Dec 28, 2015

Conversation

smiklosovic
Copy link
Member

@rmpestano

I am ready to merge when you are. Please review this once again and let me know.

It is with all your changes + jira and github bugfixes.

Thanks!

repaired bugs in jira and github implementations
@rmpestano
Copy link
Contributor

Hi @smiklosovic,

I think that's it, I will test it after the merge and come back here if something is wrong.

@smiklosovic smiklosovic merged commit 8bdfac8 into master Dec 28, 2015
@smiklosovic
Copy link
Member Author

@rmpestano in master

let me know if we can release this

@rmpestano
Copy link
Contributor

Hi @smiklosovic,

it is working great (didn't tested Jira).

There is only one thing in Governor Github which is that it is trying to close closed issues. Do you think it is aproblem? example see last 3 comments of the following issue.

For governor redmine I'm checking if issue isn't closed and then I add the comment.

I can open another PR if you think it is an issue.

@smiklosovic
Copy link
Member Author

closing closed issue is definitely a problem, could you look into that more closely please? it would be awesome if jira was tested as well

i do not have time to deal with this, i can wait ....

@rmpestano
Copy link
Contributor

Sure, I'll look into this. I also will see jira, do we have a public Jira to test governor? otherwise I will install it locally.

@smiklosovic
Copy link
Member Author

no, there is not public jira but that one in issues.jboss.org. I tested it there.

@aslakknutsen aslakknutsen added this to the 1.0.2.Final milestone Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants