New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom file extensions if defined in permalink
YAML front matter
#4314
Conversation
Your problem surfaces here: https://github.com/jekyll/jekyll/blob/master/lib/jekyll/cleaner.rb#L56. Cleaner messages |
To add, the |
I think you're right, but I'm not sure why quite yet. Consider
|
Fixes race issue. Will introduce perf issues, though...
permalink
YAML front matter.
permalink
YAML front matter.permalink
YAML front matter
Only test failures are the ones currently on master:
|
@jekyllbot: merge +bug |
Still a failing test. Fixes #4182 once it's passing.
What I'm trying to do is have
output_ext
returnFile.extname(doc.permalink)
in the case that the doc has a permalink. This means that checking if the path ends with the output extension will always return true, thus skipping the addition.I'm running into an issue where
permalink = /slides/example-slide-7.php
, butoutput_ext = .html
, so it's being appended. If I print the document, the data hasn't been read, which is awfully strange.permalink = nil
, actually, when we ask for theoutput_ext
for the first time. Super weird.@envygeeks, have a second to look at this? Super weird – why would
@site.process
in the tests not yield a fully-read document?