ProcessWord support UTF-8 #17055
Merged
ProcessWord support UTF-8 #17055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice. can we get some testcases? |
|
as @duglin says, having tests would be awesome. |
|
Sorry, I forgot to testing..... I added test case for UTF-8 strings using Korean words "안녕하세요" (it's mean hello). I write new test case based on previous test case. |
|
Oh Cool ! Unicode all the things 🙌 — with tests 😻 ありがとう |
| ch = sw.next() | ||
|
|
||
| ch = sw.scanner.Next() | ||
|
|
||
| if ch == '\000' { |
There was a problem hiding this comment.
Do we still need to check for \000 ?
|
thanks for the tests - very nice. |
|
@duglin you right. I confused \000 need for multiline .... I remove/rewrite code related with \000 |
|
@daehyeok please squash your commits |
modified PorcessWord to working normally for UTF-8 strings and added test cases Signed-off-by: Daehyeok Mun <daehyeok@gmail.com>
|
@duglin squashed, Thanks |
|
LGTM 🐰 |
|
Merging 😍 |
|
Yah, we can do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified PorcessWord to working normally for UTF-8 strings.
fixed #16793
Signed-off-by: Daehyeok Mun daehyeok@gmail.com