Network scoped alias support #19242

mavenugo · 2016-01-11T19:12:50Z

Part #2 of the proposal : #18699 which brings in the network scoped alias support.

This PR + the local alias support (#19229) fixes #18699

mavenugo · 2016-01-11T19:14:17Z

@cpuguy83 @vdemeester @calavera @icecrime I have temporarily included the engine-api vendoring commit in this PR to help CI succeed. I will rebase this PR once we have an officially vendored in the engine-api dependency.

We didn't cover the UX portion during the maintainers meeting. Hoping to get some consensus in this PR.

tiborvass · 2016-01-12T16:22:38Z

runconfig/opts/parse.go

@@ -100,6 +101,7 @@ func Parse(cmd *flag.FlagSet, args []string) (*container.Config, *container.Host
 	cmd.Var(&flVolumes, []string{"v", "-volume"}, "Bind mount a volume")
 	cmd.Var(&flTmpfs, []string{"-tmpfs"}, "Mount a tmpfs directory")
 	cmd.Var(&flLinks, []string{"-link"}, "Add link to another container")
+	cmd.Var(&flAliases, []string{"-network-alias"}, "Add network scoped alias for the container")


I suggest renaming this to --net-alias to make it more convenient and consistent with --net

also the variable name should be flNetAliases

tiborvass · 2016-01-12T16:32:11Z

UX wise:
I like docker network connect ... --alias myalias
and like I said, I would prefer changing docker run --network-alias foo ... to docker run --net-alias foo ....

Also, we should make it very clear the relationship between --net-alias and --name, and that --net-alias is not supported on the default bridge network.

Other than that, you have my +1.

cpuguy83 · 2016-01-12T16:35:02Z

What happens if you are connected to a network already and you want to use an additional alias?

mavenugo · 2016-01-12T16:37:00Z

@cpuguy83 we dont have the support to dynamically updating the alias. the only way is to disconnect and reconnect with the list of new aliases.
(also, one can use --link as a way to workaround such cases where it can be handled as a consumer side alias).

cpuguy83 · 2016-01-12T16:57:34Z

Also seems possible for multiple containers to specify the same alias on a network.
What's the expected behavior here, and is it documented?

mavenugo · 2016-01-12T17:55:03Z

@cpuguy83 yes. it is expected (and is a requirement for compose). The expected behavior in 1.10 is to provide high availability between the containers sharing the alias in that network. When one container goes down another one will start serving the request. We are not providing built-in load-balancing yet.
It is documented and I will push the docs once I get to move past the engine-api vendoring rebase.

cpuguy83 · 2016-01-12T18:20:14Z

design +1 from me as well with the changes mentioned by @tiborvass
Once you push docs and flag changes will move to code-review.

mavenugo · 2016-01-12T22:52:24Z

@cpuguy83 @tiborvass rebased on top of engine-api v0.2.1 and addressed your comments.

The docs has some dependencies on #19229. Once it is merged, I will rebase this PR again to finish up the docs. PTAL.

tiborvass · 2016-01-12T23:16:18Z

runconfig/opts/parse.go

@@ -100,6 +101,7 @@ func Parse(cmd *flag.FlagSet, args []string) (*container.Config, *container.Host
 	cmd.Var(&flVolumes, []string{"v", "-volume"}, "Bind mount a volume")
 	cmd.Var(&flTmpfs, []string{"-tmpfs"}, "Mount a tmpfs directory")
 	cmd.Var(&flLinks, []string{"-link"}, "Add link to another container")
+	cmd.Var(&flAliases, []string{"-net-alias"}, "Add network scoped alias for the container")


@mavenugo network-scoped

jessfraz · 2016-01-13T00:44:40Z

LGTM (after tibor's comments)

mavenugo · 2016-01-13T01:12:18Z

@tiborvass @jfrazelle @cpuguy83 rebased and addressed comments. PTAL.

tiborvass · 2016-01-13T01:15:01Z

api/client/network.go

@@ -115,6 +115,8 @@ func (cli *DockerCli) CmdNetworkConnect(args ...string) error {
 	flIPv6Address := cmd.String([]string{"-ip6"}, "", "IPv6 Address")
 	flLinks := opts.NewListOpts(runconfigopts.ValidateLink)
 	cmd.Var(&flLinks, []string{"-link"}, "Add link to another container")
+	flAliases := opts.NewListOpts(nil)
+	cmd.Var(&flAliases, []string{"-alias"}, "Add network scoped alias for the container")


network-scoped

i thought you'd grep it ;)

mavenugo · 2016-01-13T03:04:46Z

@tiborvass

i thought you'd grep it ;)

this time I grep'ed and caught 2 more in the comments :)... fixed now.

tiborvass · 2016-01-13T12:11:39Z

code lgtm, but haven't tested yet

mavenugo · 2016-01-13T16:47:48Z

ping @cpuguy83 @thaJeztah

cpuguy83 · 2016-01-13T18:02:52Z

One thing that's a little weird, a container that is not explicitly named can not be resolved by an alias.

tiborvass · 2016-01-14T14:07:37Z

Ping @vdemeester

vdemeester · 2016-01-14T14:08:48Z

A tiny last comment but overall great \o/.

docs LGTM 🐍

mavenugo · 2016-01-14T14:42:29Z

Windows failure is unrelated and am seeing the same failure in multiple PRs.

vdemeester · 2016-01-14T14:44:31Z

@mavenugo yep 😭
ping @thaJeztah @jamtur01 @MHBauer @moxiegirl for one last look 😉

Signed-off-by: Madhu Venugopal <madhu@docker.com>

thaJeztah · 2016-01-14T17:10:26Z

ping @mavenugo looks like you missed the network-connect man page
https://github.com/docker/docker/blob/master/man/docker-network-connect.1.md

can you add that, then we should be ready to go!

mavenugo · 2016-01-14T17:18:00Z

@thaJeztah I forgot to comment on that earlier. This particular file needs some updates for multiple options. (ip, ip6, link and alias). I thought of addressing it via the other issue opened for addressing the docs. Is that okay ?

thaJeztah · 2016-01-14T17:19:44Z

Alright, let's do that 😄

LGTM

calavera · 2016-01-14T18:58:46Z

all 💚 merging! 🎉

Network scoped alias support

mavenugo · 2016-01-14T19:00:12Z

Thanks all.
@aanand can breath now :)

vdemeester · 2016-01-14T19:02:22Z

🎉

GordonTheTurtle added the status/0-triage label Jan 11, 2016

icecrime added this to the 1.10.0 milestone Jan 11, 2016

icecrime added status/1-design-review and removed status/0-triage labels Jan 11, 2016

tiborvass reviewed Jan 12, 2016
View reviewed changes

mavenugo force-pushed the nsalias branch from e3b66fe to cd503d3 Compare January 12, 2016 22:47

tiborvass added status/2-code-review and removed status/1-design-review labels Jan 12, 2016

tiborvass reviewed Jan 12, 2016
View reviewed changes

mavenugo force-pushed the nsalias branch from cd503d3 to 17a53a5 Compare January 13, 2016 01:11

tiborvass reviewed Jan 13, 2016
View reviewed changes

mavenugo force-pushed the nsalias branch from 17a53a5 to 2c8ba02 Compare January 13, 2016 03:03

Network scoped alias support

dda513e

Signed-off-by: Madhu Venugopal <madhu@docker.com>

mavenugo force-pushed the nsalias branch from 52ba5d8 to dda513e Compare January 14, 2016 16:49

thaJeztah added status/4-merge docs/revisit and removed status/3-docs-review labels Jan 14, 2016

calavera added impact/changelog impact/cli impact/api labels Jan 14, 2016

This was referenced Jan 14, 2016

Flaky test: DockerSuite.TestEventsOOMDisableFalse #17215

Closed

Vendoring libnetwork v0.5.5 #19338

Merged

calavera added a commit that referenced this pull request Jan 14, 2016

Merge pull request #19242 from mavenugo/nsalias

73a5393

Network scoped alias support

calavera merged commit 73a5393 into moby:master Jan 14, 2016

albers mentioned this pull request Jan 18, 2016

bash completion for container linking and aliasing #19409

Merged

sdurrheimer mentioned this pull request Jan 20, 2016

Zsh completion for '--alias --net-alias --ip --ip6 --link' #19486

Merged

mavenugo mentioned this pull request Jan 20, 2016

[1.10] How to disable embedded DNS? #19474

Closed

mavenugo deleted the nsalias branch January 21, 2016 11:44

taiidani mentioned this pull request Feb 5, 2016

--net-alias support in v2 Compose File docker/compose#2829

Closed

dvenza mentioned this pull request Mar 9, 2016

Support for net aliases docker/docker-py#982

Closed

thaJeztah mentioned this pull request Dec 20, 2022

Ambiguous error message when creating a container with more than one network #44613

Closed

akerouanton mentioned this pull request Sep 18, 2023

Specify hostname on docker network connect #17805

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network scoped alias support #19242

Network scoped alias support #19242

mavenugo commented Jan 11, 2016

mavenugo commented Jan 11, 2016

tiborvass Jan 12, 2016

tiborvass Jan 12, 2016

tiborvass commented Jan 12, 2016

cpuguy83 commented Jan 12, 2016

mavenugo commented Jan 12, 2016

cpuguy83 commented Jan 12, 2016

mavenugo commented Jan 12, 2016

cpuguy83 commented Jan 12, 2016

mavenugo commented Jan 12, 2016

tiborvass Jan 12, 2016

jessfraz commented Jan 13, 2016

mavenugo commented Jan 13, 2016

tiborvass Jan 13, 2016

mavenugo commented Jan 13, 2016

tiborvass commented Jan 13, 2016

mavenugo commented Jan 13, 2016

cpuguy83 commented Jan 13, 2016

tiborvass commented Jan 14, 2016

vdemeester commented Jan 14, 2016

mavenugo commented Jan 14, 2016

vdemeester commented Jan 14, 2016

thaJeztah commented Jan 14, 2016

mavenugo commented Jan 14, 2016

thaJeztah commented Jan 14, 2016

calavera commented Jan 14, 2016

mavenugo commented Jan 14, 2016

vdemeester commented Jan 14, 2016

Network scoped alias support #19242

Network scoped alias support #19242

Conversation

mavenugo commented Jan 11, 2016

mavenugo commented Jan 11, 2016

tiborvass Jan 12, 2016

Choose a reason for hiding this comment

tiborvass Jan 12, 2016

Choose a reason for hiding this comment

tiborvass commented Jan 12, 2016

cpuguy83 commented Jan 12, 2016

mavenugo commented Jan 12, 2016

cpuguy83 commented Jan 12, 2016

mavenugo commented Jan 12, 2016

cpuguy83 commented Jan 12, 2016

mavenugo commented Jan 12, 2016

tiborvass Jan 12, 2016

Choose a reason for hiding this comment

jessfraz commented Jan 13, 2016

mavenugo commented Jan 13, 2016

tiborvass Jan 13, 2016

Choose a reason for hiding this comment

mavenugo commented Jan 13, 2016

tiborvass commented Jan 13, 2016

mavenugo commented Jan 13, 2016

cpuguy83 commented Jan 13, 2016

tiborvass commented Jan 14, 2016

vdemeester commented Jan 14, 2016

mavenugo commented Jan 14, 2016

vdemeester commented Jan 14, 2016

thaJeztah commented Jan 14, 2016

mavenugo commented Jan 14, 2016

thaJeztah commented Jan 14, 2016

calavera commented Jan 14, 2016

mavenugo commented Jan 14, 2016

vdemeester commented Jan 14, 2016