This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngMock): add support for $animate.closeAndFlush()
#13576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsko
force-pushed
the
close_and_flush
branch
from
6e85661
to
e00f016
Compare
Use `$animate.closeAndFlush()` to close all running animations. Closes angular#13005
matsko
force-pushed
the
close_and_flush
branch
from
e00f016
to
7c8c99a
Compare
| @@ -456,7 +456,7 @@ var $AnimateCssProvider = ['$animateProvider', function($animateProvider) { | |||
| var node = getDomNode(element); | |||
| if (!node | |||
| || !node.parentNode | |||
| || !$animate.enabled()) { | |||
| || !$$animateQueue.enabled()) { | |||
There was a problem hiding this comment.
ngMock decorates the $animate service with the new closeAndFlush method. Both
| @@ -63,8 +65,32 @@ var $$AnimateJsProvider = ['$animateProvider', function($animateProvider) { | |||
| applyAnimationClasses(element, options); | |||
| } | |||
|
|
|||
| function close(success) { | |||
|
LGTM (other than the unused |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
$animate.closeAndFlush()to close all running animations.Closes #13005