feat(component): disallow non-isolate scopes

Closes #13710
angular · Jan 8, 2016 · f31c5a3 · f31c5a3
1 parent 16ccac9
commit f31c5a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -967,7 +967,6 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
    *      See {@link ng.$compile#-bindtocontroller- `bindToController`}.
    *    - `transclude` – `{boolean=}` – whether {@link $compile#transclusion content transclusion} is enabled.
    *      Disabled by default.
-   *    - `isolate` – `{boolean=}` – whether the new scope is isolated. Isolated by default.
    *    - `restrict` - `{string=}` - a string containing one or more characters from {@link ng.$compile#-restrict- EACM},
    *      which restricts the component to specific directive declaration style. If omitted, this defaults to 'E'.
    *    - `$canActivate` – `{function()=}` – TBD.
@@ -982,7 +981,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
    * directives. Component definitions usually consist only of a template and a controller backing it.
    *
    * In order to make the definition easier, components enforce best practices like use of `controllerAs`,
-   * `bindToController` and default behaviors like **isolate scope** and restriction to elements.
+   * `bindToController`, **isolate scope** and default behaviors like restriction to elements.
    *
    * Here are a few examples of how you would usually define components:
    *
@@ -1071,7 +1070,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
         template: makeInjectable(template),
         templateUrl: makeInjectable(options.templateUrl),
         transclude: options.transclude,
-        scope: options.isolate === false ? true : {},
+        scope: {},
         bindToController: options.bindings || {},
         restrict: options.restrict || 'E'
       };

diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js
@@ -9352,7 +9352,6 @@ describe('$compile', function() {
         template: 'abc',
         templateUrl: 'def.html',
         transclude: true,
-        isolate: false,
         bindings: {abc: '='},
         restrict: 'EA'
       });
@@ -9364,7 +9363,7 @@ describe('$compile', function() {
           template: 'abc',
           templateUrl: 'def.html',
           transclude: true,
-          scope: true,
+          scope: {},
           bindToController: {abc: '='},
           restrict: 'EA'
         }));