This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Disallow non-isolate scope & default controllerAs to be $ctrl #13710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM (if travis is happy) 👍 |
|
LGTM - merging |
borislit
pushed a commit
to borislit/angular-component
that referenced
this pull request
Jan 9, 2016
…re scope (set it isolated by default). All this in order to be complient with latest changes to angular 1.5: angular/angular.js#13710
borislit
pushed a commit
to borislit/angular-component
that referenced
this pull request
Jan 9, 2016
…re scope (set it isolated by default). All this in order to be complient with latest changes to angular 1.5: angular/angular.js#13710
|
Oops, forgot to add a breaking change note... |
|
Right, we will have to remember to add it to the CHANGELOG. |
|
(Stating the obvious) also, remeber not to add it to the migration docs ( |
|
Or at least not to mention the "previous" form of the component helper :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.