Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose jQuery.buildFragment method #2224

Closed
markelog opened this issue Apr 21, 2015 · 3 comments
Closed

Do not expose jQuery.buildFragment method #2224

markelog opened this issue Apr 21, 2015 · 3 comments
Assignees
@timmywil
Labels
Blocker Manipulation
Milestone
1.12.0/2.2.0

Comments

@markelog
Copy link
Member

Since we will get this opportunity only i major version, marking it as a blocker
@markelog markelog added this to the 3.0.0 milestone Apr 21, 2015
@timmywil timmywil self-assigned this May 5, 2015
timmywil added a commit that referenced this issue May 5, 2015
@timmywil
Manipulation: privatize buildFragment() function
63c1414 
Fixes gh-2224
mgol referenced this issue Jun 1, 2015
@mgol
Fix #10814. Make support tests lazy and broken out to components.
bbbdd94
This was referenced Jul 31, 2015
Closed
Closed
timmywil added a commit that referenced this issue Nov 10, 2015
@timmywil @markelog
Manipulation: privatize buildFragment() function
41ca323 
Fixes gh-2224
@dmethvin dmethvin modified the milestones: 1.12/2.2, 3.0.0 Jan 7, 2016
@justinbmeyer
Copy link
Contributor

@dmethvin Was this removed in 2.2? We were using this too. Is there a list somewhere of any other privatized methods?

@dmethvin
Copy link
Member

dmethvin commented Jan 8, 2016

All the ones not documented at api.jquery.com are fair game. If you search for "do not expose" you can find them but the list i came up with earlier is .dir, .sibling, .domManip, .buildFragment, .access, .swap

@justinbmeyer
Copy link
Contributor

@dmethvin Yeah, I get that you can remove them all and be semver. Thanks for the list.

@reno1979 reno1979 mentioned this issue Jan 15, 2016
Closed
@linhe0x0 linhe0x0 mentioned this issue Feb 20, 2016
Closed
@cssmagic cssmagic mentioned this issue May 18, 2016
Open
TechQuery added a commit to TechQuery/iQuery.js that referenced this issue Jul 26, 2016
@TechQuery
【修正】兼容 jQuery v1.11.3 及以下版本 jquery/jquery#2224
fdcec58
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timmywil timmywil

Labels
Blocker Manipulation
Milestone
1.12.0/2.2.0
Development

No branches or pull requests
4 participants
@justinbmeyer @dmethvin @timmywil @markelog