tls_legacy: do not read on OpenSSL's stack

Do not attempt to read data from the socket whilst on OpenSSL's stack, weird things may happen, and this is most likely going to result in some kind of error. PR-URL: #4624 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Jan 12, 2016 · b70eec8 · b70eec8
1 parent 3912b5c
commit b70eec8
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/lib/_tls_legacy.js b/lib/_tls_legacy.js
@@ -614,13 +614,15 @@ function onclienthello(hello) {
 
     if (err) return self.socket.destroy(err);
 
-    self.ssl.loadSession(session);
-    self.ssl.endParser();
+    setImmediate(function() {
+      self.ssl.loadSession(session);
+      self.ssl.endParser();
 
-    // Cycle data
-    self._resumingSession = false;
-    self.cleartext.read(0);
-    self.encrypted.read(0);
+      // Cycle data
+      self._resumingSession = false;
+      self.cleartext.read(0);
+      self.encrypted.read(0);
+    });
   }
 
   if (hello.sessionId.length <= 0 ||