Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: require common module only once #4611

Closed
wants to merge 1 commit into from
Closed

test: require common module only once #4611

wants to merge 1 commit into from
+0 −4

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 10, 2016

Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

@Trott
test: require common module only once
312dfd4 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.
@Trott Trott added the test Issues and PRs related to the tests. label Jan 10, 2016
@mscdex
Copy link
Contributor

mscdex commented Jan 10, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Jan 10, 2016

CI: https://ci.nodejs.org/job/node-test-commit/1675/

@cjihrig
Copy link
Contributor

cjihrig commented Jan 10, 2016

LGTM

2 similar comments
@jbergstroem
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented Jan 11, 2016

LGTM

jasnell pushed a commit that referenced this pull request Jan 11, 2016
@Trott @jasnell
test: require common module only once
bfc4823 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: #4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 11, 2016

Landed in bfc4823

@jasnell jasnell closed this Jan 11, 2016
MylesBorins pushed a commit that referenced this pull request Jan 11, 2016
@Trott
test: require common module only once
1ecfd7d 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: #4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2016
@Trott
test: require common module only once
b14b2ae 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: #4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
@Trott
test: require common module only once
9fe6e5b 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: #4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
@Trott
test: require common module only once
9921175 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: #4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
@Trott
test: require common module only once
c007e47 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: nodejs#4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
@Trott
test: require common module only once
7afcdd3 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: nodejs#4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: require common module only once
4341b39 
Two tests were requiring the common module twice. This removes the
duplicate require statement in the tests.

PR-URL: nodejs#4611
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the redecl-common branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @mscdex @cjihrig @jbergstroem @jasnell @MylesBorins