Bring back click events [fixes #173] #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- call fx.unhover only on lasso and select-box starts
|
see #173 (comment) - there's a better way. |
|
💃 |
etpinard
added a commit
that referenced
this pull request
Jan 11, 2016
Bring back click events [fixes #173]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexcjohnson @mdtusz @cldougl
The lasso PR (#154) added a
fx.unhovercall which clear the hover data when drag box motions are initiated, which had the side effect of clearing the hover data for the click event emitter.This PR moves the
fx.unhovercall to theonMovedragBox handler, bringing back click event.That said, this has the side effect of making all drag boxes (e.g. select box, zoom box, colorbar, annotations and legend) clear hover upon drag.