This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
added a line that cleanup tap interface #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but... Please also remove comment in line above added ;) |
il9ue
force-pushed
the
master
branch
2 times, most recently
from
3051b07
to
608c522
Compare
|
Thanks @jellonek, just removed the comment line above, and squashed. |
|
@jonboulle IMO it's ready to be merged ;) |
| @@ -478,7 +478,7 @@ func kvmSetup(podRoot string, podID types.UUID, fps []ForwardedPort, netList com | |||
| } | |||
| err = netlink.LinkSetMaster(link, br) | |||
| if err != nil { | |||
| // TODO: cleanup tap interface | |||
| tuntap.RemovePersistentIface(n.runtime.IfName, tuntap.Tap) | |||
There was a problem hiding this comment.
Even if we ignore the error, should we print a warning with it if this fails?
There was a problem hiding this comment.
Yep. This is a good practice.
|
LGTM. Thanks! |
iaguis
added a commit
that referenced
this pull request
Jan 5, 2016
added a line that cleanup tap interface
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call RemovePersistentIface func to cleanup tap interface when error occurs.
Please give any feedback!