This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
api_service: Minor refactoring on what to return for different pod state. #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yifan-gu
commented
Dec 18, 2015
yifan-gu
commented
|
Also fix #1890 As now the api service will check the state first before fetching the pod manifest. |
yifan-gu
force-pushed
the
fix_api_service
branch
2 times, most recently
from
88dbc8f
to
564743d
Compare
|
It does not compile in Semaphore |
| string id = 1; | ||
|
|
||
| // PID of the pod, optional, only valid if it's returned by InspectPod(). A negative value means the pod has exited. | ||
| // PID of the pod. |
There was a problem hiding this comment.
Evidently I missed this earlier, but while you're here: we should probably describe which pid exactly this is, since a pod is multiple processes.
yifan-gu
force-pushed
the
fix_api_service
branch
5 times, most recently
from
5198ea9
to
18a88d9
Compare
…ate. If a pod is in Embryo, Preparing, AbortedPrepare state, only id and state will be returned. If a pod is in other states, the pod manifest and apps will be returned when 'detailed' is true in the request. Valid pid and networks are only returned when a pod is in Running.
yifan-gu
force-pushed
the
fix_api_service
branch
from
18a88d9
to
c44265f
Compare
|
lgtm |
yifan-gu
added a commit
that referenced
this pull request
Dec 20, 2015
api_service: Minor refactoring on what to return for different pod state.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.