Bug 353966 - Notifications cover panel if secondary display is taller than main
Summary: Notifications cover panel if secondary display is taller than main
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.5.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Martin Klapetek
URL: http://imgur.com/a/xvcX7
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-16 15:48 UTC by William Termini
Modified: 2016-01-20 05:35 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description William Termini 2015-10-16 15:48:50 UTC
I have a secondary monitor in portrait mode and extends above and below my main display.  However when I receive a notification it displays on top of the panel. Changing the display configuration to have the tops of both displays flush is a work around for the issue but is far from ideal to use.   You can see in this album http://imgur.com/a/xvcX7

Reproducible: Always

Steps to Reproduce:
1. Have a secondary monitor with that is taller than the main display
2. Receive a notification

Actual Results:  
The notification will cover the panel

Expected Results:  
I expected it to be below the panel
Comment 1 Martin Klapetek 2015-10-16 17:38:34 UTC
Thanks for the report.

Which Qt version are you using please?
Comment 2 William Termini 2015-10-17 13:31:33 UTC
Qt Version 5.5.0
Comment 3 William Termini 2015-10-25 12:24:09 UTC
(In reply to William Termini from comment #2)
> Qt Version 5.5.0
Comment 4 Martin Klapetek 2015-12-16 16:22:47 UTC
Ok, are you able to test patches? It's a simple patch for the
notifications applet which would help tremendously.
Comment 5 William Termini 2015-12-18 11:39:28 UTC
(In reply to Martin Klapetek from comment #4)
> Ok, are you able to test patches? It's a simple patch for the
> notifications applet which would help tremendously.

I have never tested a patch before but I am sure I could figure it out if you point me in the right direction.
Comment 6 Martin Klapetek 2016-01-05 04:54:47 UTC
Git commit 0c6b354b7e22297544f1d37608d6fdcd777c4d52 by Martin Klapetek.
Committed on 05/01/2016 at 04:52.
Pushed by mklapetek into branch 'Plasma/5.5'.

[notifications] Refactor the screen handling code

This patch does this:
* moves the screen handling code from the import into
the applet baseclass, which can access the containment
available screen rect and watch for screen changes

* fixes the applet config dialog's custom screen position
setting which has a bug of always being enabled

* consolidates duplicated code in the helper import
into functions

* ensures that popups have correct positions when on
screen that does not start with y=0 (and x=0 in some
cases too)

REVIEW: 126408
Related: bug 356461

M  +1    -0    applets/notifications/lib/CMakeLists.txt
M  +69   -25   applets/notifications/lib/notificationsapplet.cpp
M  +15   -2    applets/notifications/lib/notificationsapplet.h
M  +7    -1    applets/notifications/package/contents/ui/Notifications.qml
M  +1    -1    applets/notifications/package/contents/ui/configNotifications.qml
M  +2    -3    applets/notifications/plugin/CMakeLists.txt
M  +57   -55   applets/notifications/plugin/notificationshelper.cpp
M  +4    -2    applets/notifications/plugin/notificationshelper.h

http://commits.kde.org/plasma-workspace/0c6b354b7e22297544f1d37608d6fdcd777c4d52
Comment 7 William Termini 2016-01-20 05:35:09 UTC
Thank you for your work, I can confirm my notifications are appearing properly now.