Add support for scope in has-one association #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hasOne never had scope support, soooo ;p |
|
Haha @mickhansen that's fun... the implementation is here. Could you merge? |
|
Needs code and test for associationGetter aswell. |
|
Ok I'll do that tomorrow |
|
Great, will merge then :) |
Verdier
changed the title
|
@mickhansen done. Ready to be merged. |
mickhansen
added a commit
that referenced
this pull request
Dec 30, 2015
Add support for scope in has-one association
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix two issues:
scopewas not injected inwhereclause when eager loaded. This is extremely critical because any raw that match without thewhererestriction is eager loaded, that could result in sending private data to the client (that's what append to us...),scopewas not used is the creator helper method (ie.createInstance)