Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default charset to content-type on webrick. #4231

Merged
merged 1 commit into from Dec 7, 2015
Merged

Add a default charset to content-type on webrick. #4231

merged 1 commit into from Dec 7, 2015

Conversation

jekyllbot
Copy link
Contributor

PR automatically created for @envygeeks.

Add a default charset to content-type on webrick.

Add a default charset to content-type on webrick, using Jekyll's
default encoding (or user set encoding) and cleanup servlet removing
unecessary logic that really served no purpose at the end of the
day, we don't need to strictly match Nginx, only be "like it."

This also cleans up the way we set headers and merges that logic
into a cleaner to understand interface that is slightly speedier.```

Add a default charset to content-type on webrick.
643ae68 
Add a default charset to content-type on webrick, using Jekyll's
default encoding (or user set encoding) and cleanup servlet removing
unecessary logic that really served no purpose at the end of the
day, we don't need to strictly match Nginx, only be "like it."

This also cleans up the way we set headers and merges that logic
into a cleaner to understand interface that is slightly speedier.
@envygeeks envygeeks changed the title Add a default charset to content-type on webrick. Add a default charset to content-type on webrick, using Jekyll's default encoding (or user set encoding) and cleanup servlet removing unecessary logic that really served no purpose at the end of the day, we don't need to strictly match Nginx, only be "like it." This also cleans up the way we set headers and merges that logic into a cleaner to understand interface that is slightly speedier. Add a default charset to content-type on webrick. Dec 7, 2015
@envygeeks
Copy link
Contributor

/cc @jekyll/core

Recently while building a quick prototype I noticed a few custom fonts we offer to people were not being displayed right, ultimately it turned out to be that I forgot to set the charset in the HTML file, but it worked on the Docker image with Nginx on port 80, so I went on a crusade to figure out what the difference was and it took one minute before I realized that webrick doesn't send a charset with the content-type like Nginx, this should ease a lot of developer pains by shipping one so people aren't taken by surprise when their stuff works on Github and Nginx and Apache but not on our development servers.

@envygeeks envygeeks added this to the 3.1 milestone Dec 7, 2015
@envygeeks envygeeks self-assigned this Dec 7, 2015
parkr added a commit that referenced this pull request Dec 7, 2015
@parkr
Merge pull request #4231 from jekyll/pull/add-default-charset-to-webr…
7f9fd11 
…ick-cleanup-servlet

Merge pull request 4231
@parkr parkr merged commit 7f9fd11 into master Dec 7, 2015
@parkr parkr deleted the pull/add-default-charset-to-webrick-cleanup-servlet branch December 7, 2015 17:58
parkr added a commit that referenced this pull request Dec 7, 2015
@parkr
Update history to reflect merge of #4231
f4fa2e7 
[ci skip]
@parkr
Copy link
Member

parkr commented Dec 7, 2015

Thanks!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@envygeeks envygeeks

Labels
frozen-due-to-age
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jekyllbot @envygeeks @parkr