Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #4219: Add CodeClimate Platform. #4220

Merged
merged 1 commit into from Dec 4, 2015

Conversation

jekyllbot
Copy link
Contributor

PR automatically created for @envygeeks.

Fix: #4219: Add CodeClimate Platform.

@envygeeks
Copy link
Contributor

Initial analysis:

Starting analysis

== Rakefile (9 issues) ==
7: `%w`-literals should be delimited by `(` and `)`. [rubocop]
33: Redundant use of `Object#to_s` in interpolation. [rubocop]
199-204: `%w`-literals should be delimited by `(` and `)`. [rubocop]
259: Unused block argument - `t`. If it's necessary, use `_` or `_t` as an argument name to indicate that it won't be used. [rubocop]
261: Do not use `Time.new.strftime` without zone. Use one of `Time.zone.new.strftime`, `Time.new.strftime.current`, `Time.new.strftime.in_time_zone`, `Time.new.strftime.utc`, `Time.new.strftime.getlocal`, `Time.new.strftime.iso8601`, `Time.new.strftime.jisx0301`, `Time.new.strftime.rfc3339`, `Time.new.strftime.to_i`, `Time.new.strftime.to_f` instead. [rubocop]
263: Prefer double-quoted strings inside interpolations. [rubocop]
263: Prefer double-quoted strings inside interpolations. [rubocop]
269: Do not use `Time.new.strftime` without zone. Use one of `Time.zone.new.strftime`, `Time.new.strftime.current`, `Time.new.strftime.in_time_zone`, `Time.new.strftime.utc`, `Time.new.strftime.getlocal`, `Time.new.strftime.iso8601`, `Time.new.strftime.jisx0301`, `Time.new.strftime.rfc3339`, `Time.new.strftime.to_i`, `Time.new.strftime.to_f` instead. [rubocop]
269: Prefer double-quoted strings inside interpolations. [rubocop]

== bin/jekyll (4 issues) ==
4: Prefer `$LOAD_PATH` over `$:`. [rubocop]
4: `%w`-literals should be delimited by `(` and `)`. [rubocop]
25: Line is too long. [130/112] [rubocop]
31: Unused block argument - `options`. If it's necessary, use `_` or `_options` as an argument name to indicate that it won't be used. [rubocop]

== features/step_definitions/jekyll_steps.rb (49 issues) ==
2: Unused block argument - `v`. If it's necessary, use `_` or `_v` as an argument name to indicate that it won't be used. [rubocop]
6: Use 2 (not -8) spaces for indentation. [rubocop]
6: Prefer double-quoted strings inside interpolations. [rubocop]
6: Prefer double-quoted strings inside interpolations. [rubocop]
7: Align `else` with `if`. [rubocop]
9: `end` at 9, 2 is not aligned with `if` at 5, 12. [rubocop]
25: Unnecessary spacing detected. [rubocop]
35: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
39: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
44: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
48: Prefer double-quoted strings inside interpolations. [rubocop]
48: Prefer double-quoted strings inside interpolations. [rubocop]
55: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
61: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
63: Use 2 (not -7) spaces for indentation. [rubocop]
64: Align `else` with `if`. [rubocop]
66: `end` at 66, 2 is not aligned with `if` at 62, 11. [rubocop]
77: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
83: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
87: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
87: Line is too long. [115/112] [rubocop]
101: Do not use `Time.parse` without zone. Use one of `Time.zone.parse`, `Time.parse.current`, `Time.parse.in_time_zone`, `Time.parse.utc`, `Time.parse.getlocal`, `Time.parse.iso8601`, `Time.parse.jisx0301`, `Time.parse.rfc3339`, `Time.parse.to_i`, `Time.parse.to_f` instead. [rubocop]
103: Prefer double-quoted strings inside interpolations. [rubocop]
113: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
119: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
127: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
136: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
140: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
140: Unused block argument - `plural`. If it's necessary, use `_` or `_plural` as an argument name to indicate that it won't be used. [rubocop]
150: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
151: Useless assignment to variable - `status`. [rubocop]
157: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
158: Useless assignment to variable - `status`. [rubocop]
164: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
170: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
180: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
184: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
188: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
192: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
196: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
200: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
204: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
216: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
220: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
221: Do not use `Time.now.new` without zone. Use one of `Time.zone.now.new`, `Time.now.new.current`, `Time.now.new.in_time_zone`, `Time.now.new.utc`, `Time.now.new.getlocal`, `Time.now.new.iso8601`, `Time.now.new.jisx0301`, `Time.now.new.rfc3339`, `Time.now.new.to_i`, `Time.now.new.to_f` instead. [rubocop]
224: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
225: Do not use `Date.today` without zone. Use `Time.zone.today` instead. [rubocop]
228: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]
232: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]

== features/support/env.rb (3 issues) ==
82: Do not use `Time.now.strftime` without zone. Use one of `Time.zone.now.strftime`, `Time.now.strftime.current`, `Time.now.strftime.in_time_zone`, `Time.now.strftime.utc`, `Time.now.strftime.getlocal`, `Time.now.strftime.iso8601`, `Time.now.strftime.jisx0301`, `Time.now.strftime.rfc3339`, `Time.now.strftime.to_i`, `Time.now.strftime.to_f` instead. [rubocop]
100: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.now.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.to_i`, `Time.now.to_f` instead. [rubocop]
114: Do not use trailing `_`s in parallel assignment. [rubocop]

== features/support/overview.rb (24 issues) ==
23: Do not use parallel assignment. [rubocop]
30: Unused method argument - `features`. If it's necessary, use `_` or `_features` as an argument name to indicate that it won't be used. You can also write as `before_features(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
39: Unused method argument - `feature`. If it's necessary, use `_` or `_feature` as an argument name to indicate that it won't be used. You can also write as `before_feature(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
44: Unused method argument - `comment_line`. If it's necessary, use `_` or `_comment_line` as an argument name to indicate that it won't be used. You can also write as `comment_line(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
47: Unused method argument - `tags`. If it's necessary, use `_` or `_tags` as an argument name to indicate that it won't be used. You can also write as `after_tags(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
50: Unused method argument - `tag_name`. If it's necessary, use `_` or `_tag_name` as an argument name to indicate that it won't be used. You can also write as `tag_name(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
53: Unused method argument - `feature_element`. If it's necessary, use `_` or `_feature_element` as an argument name to indicate that it won't be used. You can also write as `before_feature_element(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
58: Unused method argument - `feature_element`. If it's necessary, use `_` or `_feature_element` as an argument name to indicate that it won't be used. You can also write as `after_feature_element(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
61: Unused method argument - `background`. If it's necessary, use `_` or `_background` as an argument name to indicate that it won't be used. You can also write as `before_background(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
67: Unused method argument - `background`. If it's necessary, use `_` or `_background` as an argument name to indicate that it won't be used. You can also write as `after_background(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
83: Avoid parameter lists longer than 5 parameters. [rubocop]
83: Unused method argument - `keyword`. If it's necessary, use `_` or `_keyword` as an argument name to indicate that it won't be used. [rubocop]
83: Unused method argument - `step_match`. If it's necessary, use `_` or `_step_match` as an argument name to indicate that it won't be used. [rubocop]
83: Unused method argument - `multiline_arg`. If it's necessary, use `_` or `_multiline_arg` as an argument name to indicate that it won't be used. [rubocop]
83: Unused method argument - `source_indent`. If it's necessary, use `_` or `_source_indent` as an argument name to indicate that it won't be used. [rubocop]
83: Unused method argument - `file_colon_line`. If it's necessary, use `_` or `_file_colon_line` as an argument name to indicate that it won't be used. [rubocop]
83: Line is too long. [127/112] [rubocop]
107: Avoid parameter lists longer than 5 parameters. [rubocop]
107: Unused method argument - `keyword`. If it's necessary, use `_` or `_keyword` as an argument name to indicate that it won't be used. [rubocop]
107: Unused method argument - `step_match`. If it's necessary, use `_` or `_step_match` as an argument name to indicate that it won't be used. [rubocop]
107: Unused method argument - `source_indent`. If it's necessary, use `_` or `_source_indent` as an argument name to indicate that it won't be used. [rubocop]
107: Unused method argument - `background`. If it's necessary, use `_` or `_background` as an argument name to indicate that it won't be used. [rubocop]
107: Unused method argument - `file_colon_line`. If it's necessary, use `_` or `_file_colon_line` as an argument name to indicate that it won't be used. [rubocop]
120: Unused method argument - `source_indent`. If it's necessary, use `_` or `_source_indent` as an argument name to indicate that it won't be used. [rubocop]

== jekyll-docs.gemspec (2 issues) ==
11: Use `%q` only for strings that contain both single quotes and double quotes. [rubocop]
15: `%r`-literals should be delimited by `!` and `!`. [rubocop]

== jekyll.gemspec (3 issues) ==
24: `%r`-literals should be delimited by `!` and `!`. [rubocop]
25: `%r`-literals should be delimited by `!` and `!`. [rubocop]
29: `%w`-literals should be delimited by `(` and `)`. [rubocop]

== lib/jekyll.rb (5 issues) ==
1: Prefer `$LOAD_PATH` over `$:`. [rubocop]
98: Use hash literal `{}` instead of `Hash.new`. [rubocop]
117: Do not prefix writer method names with `set_`. [rubocop]
159-163: Do not use `unless` with `else`. Rewrite these with the positive case first. [rubocop]
168-169: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/cleaner.rb (1 issue) ==
16: Favor `unless` over `if` for negative conditions. [rubocop]

== lib/jekyll/collection.rb (6 issues) ==
54-72: Assignment Branch Condition size for read is too high. [31.4/15] [rubocop]
79: Use array literal `[]` instead of `Array.new`. [rubocop]
82: Do not use semicolons to terminate expressions. [rubocop]
91: Use array literal `[]` instead of `Array.new`. [rubocop]
196: Use 2 (not 4) spaces for indentation. [rubocop]
205: Use hash literal `{}` instead of `Hash.new`. [rubocop]

== lib/jekyll/command.rb (9 issues) ==
3-4: Extra empty line detected at class body beginning. [rubocop]
5-6: Extra empty line detected at class body beginning. [rubocop]
51: Unnecessary spacing detected. [rubocop]
52: Line is too long. [122/112] [rubocop]
55: Line is too long. [117/112] [rubocop]
56: Unnecessary spacing detected. [rubocop]
58: Unnecessary spacing detected. [rubocop]
65-66: Extra empty line detected at class body end. [rubocop]
67-68: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/commands/build.rb (12 issues) ==
4-5: Extra empty line detected at class body beginning. [rubocop]
6-7: Extra empty line detected at class body beginning. [rubocop]
10: Put one space between the method name and the first argument. [rubocop]
16: Unused block argument - `args`. If it's necessary, use `_` or `_args` as an argument name to indicate that it won't be used. [rubocop]
33: Line is too long. [118/112] [rubocop]
51-62: Assignment Branch Condition size for build is too high. [18.47/15] [rubocop]
52: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.now.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.to_i`, `Time.now.to_f` instead. [rubocop]
58: Line is too long. [116/112] [rubocop]
61: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.now.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.to_i`, `Time.now.to_f` instead. [rubocop]
70: Unused method argument - `site`. If it's necessary, use `_` or `_site` as an argument name to indicate that it won't be used. [rubocop]
74-75: Extra empty line detected at class body end. [rubocop]
76-77: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/commands/clean.rb (4 issues) ==
5-6: Extra empty line detected at class body beginning. [rubocop]
13: Unused block argument - `args`. If it's necessary, use `_` or `_args` as an argument name to indicate that it won't be used. [rubocop]
19-39: Assignment Branch Condition size for process is too high. [20.32/15] [rubocop]
40-41: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/commands/doctor.rb (12 issues) ==
5-6: Extra empty line detected at class body beginning. [rubocop]
14: Unused block argument - `args`. If it's necessary, use `_` or `_args` as an argument name to indicate that it won't be used. [rubocop]
41: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
42: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
42: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
43: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
53: Use `next` to skip iteration. [rubocop]
56: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
63: Unused method argument - `site`. If it's necessary, use `_` or `_site` as an argument name to indicate that it won't be used. You can also write as `fsnotify_buggy?(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
64: Favor `unless` over `if` for negative conditions. [rubocop]
91-92: Extra empty line detected at class body end. [rubocop]
93-94: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/commands/help.rb (5 issues) ==
5-6: Extra empty line detected at class body beginning. [rubocop]
14: Do not write to stdout. Use Rails' logger if you want to log. [rubocop]
16: Do not write to stdout. Use Rails' logger if you want to log. [rubocop]
27: Put one space between the method name and the first argument. [rubocop]
29-30: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/commands/new.rb (4 issues) ==
21-41: Assignment Branch Condition size for process is too high. [20.25/15] [rubocop]
22: Provide an exception class and message as arguments to `raise`. [rubocop]
58: Do not use `Time.now.strftime` without zone. Use one of `Time.zone.now.strftime`, `Time.now.strftime.current`, `Time.now.strftime.in_time_zone`, `Time.now.strftime.utc`, `Time.now.strftime.getlocal`, `Time.now.strftime.iso8601`, `Time.now.strftime.jisx0301`, `Time.now.strftime.rfc3339`, `Time.now.strftime.to_i`, `Time.now.strftime.to_f` instead. [rubocop]
58: Prefer double-quoted strings inside interpolations. [rubocop]

== lib/jekyll/commands/serve.rb (18 issues) ==
5-6: Extra empty line detected at class body beginning. [rubocop]
7-8: Extra empty line detected at class body beginning. [rubocop]
8-31: Assignment Branch Condition size for init_with_program is too high. [18.03/15] [rubocop]
21: Line is too long. [140/112] [rubocop]
24: Unused block argument - `args`. If it's necessary, use `_` or `_args` as an argument name to indicate that it won't be used. [rubocop]
34-77: Assignment Branch Condition size for process is too high. [33.12/15] [rubocop]
34-77: Cyclomatic complexity for process is too high. [7/6] [rubocop]
34-77: Perceived complexity for process is too high. [9/7] [rubocop]
34-77: Method has too many lines. [35/24] [rubocop]
71: Line is too long. [132/112] [rubocop]
87-90: Method definitions must not be nested. Use `lambda` instead. [rubocop]
125-131: Method definitions must not be nested. Use `lambda` instead. [rubocop]
137: Use `proc` instead of `Proc.new`. [rubocop]
143: Do not use `::` for method calls. [rubocop]
147: Prefer double-quoted strings inside interpolations. [rubocop]
161: Space missing after comma. [rubocop]
164-165: Extra empty line detected at class body end. [rubocop]
166-167: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/configuration.rb (48 issues) ==
5-6: Extra empty line detected at class body beginning. [rubocop]
22: Space missing after comma. [rubocop]
44: Unnecessary spacing detected. [rubocop]
52: Unnecessary spacing detected. [rubocop]
89: Space missing after comma. [rubocop]
89: Space missing after comma. [rubocop]
132-147: Assignment Branch Condition size for config_files is too high. [15.94/15] [rubocop]
139: `%w`-literals should be delimited by `(` and `)`. [rubocop]
139: Use `proc` instead of `Proc.new`. [rubocop]
156: Provide an exception class and message as arguments to `raise`. [rubocop]
184: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
185: Use 2 (not 13) spaces for indenting an expression spanning multiple lines. [rubocop]
205-264: Perceived complexity for backwards_compatibilize is too high. [10/7] [rubocop]
205-264: Method has too many lines. [49/24] [rubocop]
205-264: Cyclomatic complexity for backwards_compatibilize is too high. [10/6] [rubocop]
205-264: Assignment Branch Condition size for backwards_compatibilize is too high. [55.74/15] [rubocop]
209: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
210: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
210: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
211: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
217: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
218: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
218: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
219: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
229: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
230: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
230: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
231: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
231: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
232: Use 2 (not 20) spaces for indenting an expression spanning multiple lines. [rubocop]
238: `%w`-literals should be delimited by `(` and `)`. [rubocop]
240: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
241: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
242: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
250: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
256: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
257: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
258: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
259: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
270: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
271: Prefer double-quoted strings inside interpolations. [rubocop]
278-291: Assignment Branch Condition size for add_default_collections is too high. [19.21/15] [rubocop]
284: Space missing to the left of {. [rubocop]
284: Space between { and | missing. [rubocop]
284: Space missing inside }. [rubocop]
293: Unused method argument - `allowed_values`. If it's necessary, use `_` or `_allowed_values` as an argument name to indicate that it won't be used. [rubocop]
295: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
296: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]

== lib/jekyll/converters/identity.rb (1 issue) ==
8: Unused method argument - `ext`. If it's necessary, use `_` or `_ext` as an argument name to indicate that it won't be used. You can also write as `matches(*)` if you want the method to accept any arguments but don't care about them. [rubocop]

== lib/jekyll/converters/markdown.rb (11 issues) ==
9-27: Assignment Branch Condition size for setup is too high. [20.71/15] [rubocop]
13: Indent `when` as deep as `case`. [rubocop]
14: Indent `when` as deep as `case`. [rubocop]
15: Indent `when` as deep as `case`. [rubocop]
16: Align `else` with `when`. [rubocop]
18: Use 2 (not 0) spaces for indentation. [rubocop]
21: Prefer double-quoted strings inside interpolations. [rubocop]
23: Prefer double-quoted strings inside interpolations. [rubocop]
30-34: `%w`-literals should be delimited by `(` and `)`. [rubocop]
38-43: `%w`-literals should be delimited by `(` and `)`. [rubocop]
54: Unused method argument - `ext`. If it's necessary, use `_` or `_ext` as an argument name to indicate that it won't be used. You can also write as `output_ext(*)` if you want the method to accept any arguments but don't care about them. [rubocop]

== lib/jekyll/converters/markdown/kramdown_parser.rb (4 issues) ==
16: Provide an exception class and message as arguments to `raise`. [rubocop]
22: `%w`-literals should be delimited by `(` and `)`. [rubocop]
24: Line is too long. [113/112] [rubocop]
30-31: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/converters/markdown/rdiscount_parser.rb (1 issue) ==
8: Pass `&:to_sym` as an argument to `map` instead of a block. [rubocop]

== lib/jekyll/converters/markdown/redcarpet_parser.rb (7 issues) ==
5-6: Extra empty line detected at class body beginning. [rubocop]
10: Useless assignment to variable - `code`. [rubocop]
10: Space missing after comma. [rubocop]
32: Do not use `::` for method calls. [rubocop]
51: Unused method argument - `lexer`. If it's necessary, use `_` or `_lexer` as an argument name to indicate that it won't be used. You can also write as `rouge_formatter(*)` if you want the method to accept any arguments but don't care about them. [rubocop]
56-57: Extra blank line detected. [rubocop]
74-77: `%w`-literals should be delimited by `(` and `)`. [rubocop]

== lib/jekyll/convertible.rb (20 issues) ==
44-65: Assignment Branch Condition size for read_yaml is too high. [25.36/15] [rubocop]
50: Avoid the use of Perl-style backrefs. [rubocop]
54-55: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? [rubocop]
75: Line is too long. [120/112] [rubocop]
90: Avoid using `{...}` for multi-line blocks. [rubocop]
111-119: Assignment Branch Condition size for render_liquid is too high. [16.4/15] [rubocop]
116-118: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? [rubocop]
125: Avoid using `{...}` for multi-line blocks. [rubocop]
163: `%w`-literals should be delimited by `(` and `)`. [rubocop]
203-234: Assignment Branch Condition size for render_all_layouts is too high. [38.54/15] [rubocop]
207: Line is too long. [135/112] [rubocop]
211: Use `next` to skip iteration. [rubocop]
213: Space inside { missing. [rubocop]
213: Space inside } missing. [rubocop]
242-266: Assignment Branch Condition size for do_layout is too high. [40.06/15] [rubocop]
243: Redundant `self` detected. [rubocop]
245: Redundant `self` detected. [rubocop]
254: Redundant `self` detected. [rubocop]
257: Redundant `self` detected. [rubocop]
264: Redundant `self` detected. [rubocop]

== lib/jekyll/deprecator.rb (3 issues) ==
3: Use `module_function` instead of `extend self`. [rubocop]
24: `%w`-literals should be delimited by `(` and `)`. [rubocop]
25: Line is too long. [121/112] [rubocop]

== lib/jekyll/document.rb (38 issues) ==
4-474: Class has too many lines. [276/240] [rubocop]
19-38: Assignment Branch Condition size for initialize is too high. [21.86/15] [rubocop]
33: Unused block argument - `hash`. If it's necessary, use `_` or `_hash` as an argument name to indicate that it won't be used. [rubocop]
55: Use hash literal `{}` instead of `Hash.new`. [rubocop]
61-73: Assignment Branch Condition size for merge_data! is too high. [31.58/15] [rubocop]
61-73: Cyclomatic complexity for merge_data! is too high. [7/6] [rubocop]
70: Use 2 (not 3) spaces for indentation. [rubocop]
70: Line is too long. [143/112] [rubocop]
123: Space inside range literal. [rubocop]
130: `%w`-literals should be delimited by `(` and `)`. [rubocop]
146: `%w`-literals should be delimited by `(` and `)`. [rubocop]
175: Use `delegate` to define delegations. [rubocop]
183-205: Assignment Branch Condition size for url_placeholders is too high. [45.1/15] [rubocop]
190: Use 2 (not 15) spaces for indenting an expression spanning multiple lines. [rubocop]
203: Avoid comma after the last item of a hash. [rubocop]
226: Use `delegate` to define delegations. [rubocop]
280-306: Assignment Branch Condition size for read is too high. [31/15] [rubocop]
295: Avoid the use of Perl-style backrefs. [rubocop]
301: Do not write to stdout. Use Rails' logger if you want to log. [rubocop]
302-303: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? [rubocop]
303: Do not write to stdout. Use Rails' logger if you want to log. [rubocop]
308-324: Assignment Branch Condition size for post_read is too high. [29.55/15] [rubocop]
310: Useless assignment to variable - `m`. Use `_` or `_m` as a variable name to indicate that it won't be used. [rubocop]
310: Useless assignment to variable - `cats`. Use `_` or `_cats` as a variable name to indicate that it won't be used. [rubocop]
315: Space inside { missing. [rubocop]
315: Space inside } missing. [rubocop]
316: Space between { and | missing. [rubocop]
340-342: Pass `&:to_s` as an argument to `map` instead of a block. [rubocop]
355-371: Assignment Branch Condition size for to_liquid is too high. [19.13/15] [rubocop]
357: Use 2 (not -13) spaces for indentation. [rubocop]
366: Avoid comma after the last item of a hash. [rubocop]
368: Align `else` with `if`. [rubocop]
370: `end` at 370, 6 is not aligned with `if` at 356, 21. [rubocop]
394: Favor `unless` over `if` for negative conditions. [rubocop]
425: Space between { and | missing. [rubocop]
428: Redundant `else`-clause. [rubocop]
434: Space between { and | missing. [rubocop]
437: Redundant `else`-clause. [rubocop]

== lib/jekyll/excerpt.rb (2 issues) ==
9: Put one space between the method name and the first argument. [rubocop]
72: Redundant `self` detected. [rubocop]

== lib/jekyll/external.rb (4 issues) ==
4-5: Extra empty line detected at class body beginning. [rubocop]
10-13: `%w`-literals should be delimited by `(` and `)`. [rubocop]
52: Provide an exception class and message as arguments to `raise`. [rubocop]
56-57: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/filters.rb (20 issues) ==
47: Surrounding space missing in default value assignment. [rubocop]
124: Do not use `::` for method calls. [rubocop]
171: Prefer double-quoted strings inside interpolations. [rubocop]
196: Avoid multi-line chains of blocks. [rubocop]
197: Space inside { missing. [rubocop]
197: Space inside } missing. [rubocop]
224-254: Assignment Branch Condition size for sort is too high. [25.61/15] [rubocop]
224-254: Method has too many lines. [27/24] [rubocop]
224-254: Perceived complexity for sort is too high. [11/7] [rubocop]
224-254: Cyclomatic complexity for sort is too high. [9/6] [rubocop]
226: Use 2 (not 4) spaces for indentation. [rubocop]
226: Provide an exception class and message as arguments to `raise`. [rubocop]
237-238: Provide an exception class and message as arguments to `raise`. [rubocop]
237: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
241: Avoid using `{...}` for multi-line blocks. [rubocop]
299: Do not use `to_time` on Date objects,because it knows nothing about time zone in use. [rubocop]
301: Do not use `Time.parse` without zone. Use one of `Time.zone.parse`, `Time.parse.current`, `Time.parse.in_time_zone`, `Time.parse.utc`, `Time.parse.getlocal`, `Time.parse.iso8601`, `Time.parse.jisx0301`, `Time.parse.rfc3339`, `Time.parse.to_i`, `Time.parse.to_f` instead. [rubocop]
301: Do not use `Time.at` without zone. Use one of `Time.zone.at`, `Time.at.current`, `Time.at.in_time_zone`, `Time.at.utc`, `Time.at.getlocal`, `Time.at.iso8601`, `Time.at.jisx0301`, `Time.at.rfc3339`, `Time.at.to_i`, `Time.at.to_f` instead. [rubocop]
303: Do not use `Time.at` without zone. Use one of `Time.zone.at`, `Time.at.current`, `Time.at.in_time_zone`, `Time.at.utc`, `Time.at.getlocal`, `Time.at.iso8601`, `Time.at.jisx0301`, `Time.at.rfc3339`, `Time.at.to_i`, `Time.at.to_f` instead. [rubocop]
330: Space missing to the left of {. [rubocop]

== lib/jekyll/frontmatter_defaults.rb (7 issues) ==
17: Indent `when` as deep as `case`. [rubocop]
20: Indent `when` as deep as `case`. [rubocop]
23: Indent `when` as deep as `case`. [rubocop]
86: `Hash#has_key?` is deprecated in favor of `Hash#key?`. [rubocop]
89: Shadowing outer local variable - `path`. [rubocop]
126: Rename `has_precedence?` to `precedence?`. [rubocop]
146: `Hash#has_key?` is deprecated in favor of `Hash#key?`. [rubocop]

== lib/jekyll/hooks.rb (8 issues) ==
9: Avoid comma after the last item of a hash. [rubocop]
19: Avoid comma after the last item of a hash. [rubocop]
25: Avoid comma after the last item of a hash. [rubocop]
31: Avoid comma after the last item of a hash. [rubocop]
37: Avoid comma after the last item of a hash. [rubocop]
38: Avoid comma after the last item of a hash. [rubocop]
66: Avoid comma after the last item of a hash. [rubocop]
70: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]

== lib/jekyll/liquid_renderer.rb (1 issue) ==
18: Unused block argument - `file`. You can omit the argument if you don't care about it. [rubocop]

== lib/jekyll/liquid_renderer/file.rb (2 issues) ==
42: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.now.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.to_i`, `Time.now.to_f` instead. [rubocop]
45: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.now.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.to_i`, `Time.now.to_f` instead. [rubocop]

== lib/jekyll/liquid_renderer/table.rb (6 issues) ==
2: Use nested module/class definitions instead of compact style. [rubocop]
71-87: Assignment Branch Condition size for data_for_table is too high. [16.49/15] [rubocop]
72: Space missing to the left of {. [rubocop]
72: Unused block argument - `filename`. If it's necessary, use `_` or `_filename` as an argument name to indicate that it won't be used. [rubocop]
82: Favor `format` over `String#%`. [rubocop]
91: Favor `format` over `String#%`. [rubocop]

== lib/jekyll/page.rb (5 issues) ==
11-17: `%w`-literals should be delimited by `(` and `)`. [rubocop]
40-41: Extra blank line detected. [rubocop]
44: Unused block argument - `hash`. If it's necessary, use `_` or `_hash` as an argument name to indicate that it won't be used. [rubocop]
110: Space inside range literal. [rubocop]
148: Unnecessary spacing detected. [rubocop]

== lib/jekyll/plugin.rb (2 issues) ==
56: Redundant `self` detected. [rubocop]
73: Unused method argument - `config`. If it's necessary, use `_` or `_config` as an argument name to indicate that it won't be used. You can also write as `initialize(*)` if you want the method to accept any arguments but don't care about them. [rubocop]

== lib/jekyll/plugin_manager.rb (6 issues) ==
40: Prefer double-quoted strings inside interpolations. [rubocop]
84-90: Assignment Branch Condition size for plugins_path is too high. [16.03/15] [rubocop]
93: Line is too long. [113/112] [rubocop]
95: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
96: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
100-101: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/reader.rb (13 issues) ==
15-21: Assignment Branch Condition size for read is too high. [16/15] [rubocop]
25: Space missing to the left of {. [rubocop]
25: Space between { and | missing. [rubocop]
25: Space missing inside }. [rubocop]
37-50: Assignment Branch Condition size for read_directories is too high. [18.03/15] [rubocop]
41: Space missing to the left of {. [rubocop]
41: Space missing after comma. [rubocop]
43: Space missing to the left of {. [rubocop]
43: Space missing after comma. [rubocop]
58-61: Assignment Branch Condition size for retrieve_posts is too high. [16.03/15] [rubocop]
70: Unused method argument - `base`. If it's necessary, use `_` or `_base` as an argument name to indicate that it won't be used. [rubocop]
71: Avoid using `{...}` for multi-line blocks. [rubocop]
72: Space missing after comma. [rubocop]

== lib/jekyll/readers/collection_reader.rb (2 issues) ==
3: `%w`-literals should be delimited by `(` and `)`. [rubocop]
19-20: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/readers/data_reader.rb (5 issues) ==
28-46: Cyclomatic complexity for read_data_to is too high. [7/6] [rubocop]
28-46: Assignment Branch Condition size for read_data_to is too high. [24.92/15] [rubocop]
28-46: Perceived complexity for read_data_to is too high. [8/7] [rubocop]
53: Indent `when` as deep as `case`. [rubocop]
55: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is. [rubocop]

== lib/jekyll/readers/layout_reader.rb (1 issue) ==
48: Redundant `else`-clause. [rubocop]

== lib/jekyll/readers/page_reader.rb (3 issues) ==
7: Use array literal `[]` instead of `Array.new`. [rubocop]
17: Space missing to the left of {. [rubocop]
18: Space missing to the left of {. [rubocop]

== lib/jekyll/readers/post_reader.rb (1 issue) ==
37: Avoid multi-line chains of blocks. [rubocop]

== lib/jekyll/readers/static_file_reader.rb (3 issues) ==
7: Use array literal `[]` instead of `Array.new`. [rubocop]
17: Space missing to the left of {. [rubocop]
17: Space missing inside }. [rubocop]

== lib/jekyll/regenerator.rb (17 issues) ==
18-35: Perceived complexity for regenerate? is too high. [8/7] [rubocop]
18-35: Cyclomatic complexity for regenerate? is too high. [9/6] [rubocop]
18-35: Assignment Branch Condition size for regenerate? is too high. [24.43/15] [rubocop]
65-66: Extra blank line detected. [rubocop]
73-74: Extra blank line detected. [rubocop]
79: Use `&&` instead of `and`. [rubocop]
86-114: Assignment Branch Condition size for modified? is too high. [24.06/15] [rubocop]
86-114: Perceived complexity for modified? is too high. [9/7] [rubocop]
86-114: Cyclomatic complexity for modified? is too high. [8/6] [rubocop]
93: `Hash#has_key?` is deprecated in favor of `Hash#key?`. [rubocop]
113: Redundant `return` detected. [rubocop]
119-127: Assignment Branch Condition size for add_dependency is too high. [16.49/15] [rubocop]
120: Don't use parentheses around the condition of an `if`. [rubocop]
122-125: Favor `unless` over `if` for negative conditions. [rubocop]
161: Use 2 (not -10) spaces for indentation. [rubocop]
171: Align `else` with `if`. [rubocop]
173: `end` at 173, 6 is not aligned with `if` at 160, 18. [rubocop]

== lib/jekyll/related_posts.rb (2 issues) ==
3-4: Extra empty line detected at class body beginning. [rubocop]
27-28: Extra blank line detected. [rubocop]

== lib/jekyll/renderer.rb (13 issues) ==
5-6: Extra empty line detected at class body beginning. [rubocop]
33-77: Assignment Branch Condition size for run is too high. [61.41/15] [rubocop]
33-77: Method has too many lines. [33/24] [rubocop]
89: Line is too long. [138/112] [rubocop]
104-112: Assignment Branch Condition size for render_liquid is too high. [18.36/15] [rubocop]
107: Line is too long. [121/112] [rubocop]
109-111: Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`? [rubocop]
129-170: Assignment Branch Condition size for place_in_layouts is too high. [46.8/15] [rubocop]
129-170: Method has too many lines. [32/24] [rubocop]
133: Line is too long. [162/112] [rubocop]
135: Unnecessary spacing detected. [rubocop]
137: Use `next` to skip iteration. [rubocop]
171-172: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/site.rb (32 issues) ==
6: Put one space between the method name and the first argument. [rubocop]
14: Put one space between the method name and the first argument. [rubocop]
19-50: Assignment Branch Condition size for initialize is too high. [30.61/15] [rubocop]
22-23: `%w`-literals should be delimited by `(` and `)`. [rubocop]
23: Align the elements of an array literal if they span more than one line. [rubocop]
24: Redundant `self` detected. [rubocop]
42: Redundant `self` detected. [rubocop]
67: Do not write to stdout. Use Rails' logger if you want to log. [rubocop]
74-89: Assignment Branch Condition size for reset is too high. [18.14/15] [rubocop]
75: Line is too long. [117/112] [rubocop]
75: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.now.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.to_i`, `Time.now.to_f` instead. [rubocop]
109: Provide an exception class and message as arguments to `raise`. [rubocop]
161-186: Assignment Branch Condition size for render is too high. [21.24/15] [rubocop]
168: Unused block argument - `label`. If it's necessary, use `_` or `_label` as an argument name to indicate that it won't be used. [rubocop]
184: Do not suppress exceptions. [rubocop]
199: Avoid using `{...}` for multi-line blocks. [rubocop]
261-281: Assignment Branch Condition size for site_payload is too high. [27.02/15] [rubocop]
267: Unnecessary spacing detected. [rubocop]
268: Space between { and | missing. [rubocop]
268: Space missing to the left of {. [rubocop]
268: Space missing inside }. [rubocop]
302: Avoid multi-line chains of blocks. [rubocop]
313: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
314: Use 2 (not 24) spaces for indenting an expression spanning multiple lines. [rubocop]
314: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
315: Use 2 (not 24) spaces for indenting an expression spanning multiple lines. [rubocop]
315: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
316: Use 2 (not 24) spaces for indenting an expression spanning multiple lines. [rubocop]
316: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
317: Use 2 (not 24) spaces for indenting an expression spanning multiple lines. [rubocop]
397-402: Assignment Branch Condition size for limit_posts! is too high. [17.15/15] [rubocop]
400: Redundant `self` detected. [rubocop]

== lib/jekyll/static_file.rb (13 issues) ==
4: Replace class var @@mtimes with a class instance var. [rubocop]
4: Use hash literal `{}` instead of `Hash.new`. [rubocop]
75-87: Assignment Branch Condition size for write is too high. [18.28/15] [rubocop]
78: Use `&&` instead of `and`. [rubocop]
93: Replace class var @@mtimes with a class instance var. [rubocop]
93: Use hash literal `{}` instead of `Hash.new`. [rubocop]
112: Avoid comma after the last item of a hash. [rubocop]
121: Use 2 (not -7) spaces for indentation. [rubocop]
122: Align `else` with `if`. [rubocop]
124: Unnecessary spacing detected. [rubocop]
125: Avoid comma after the last item of a hash. [rubocop]
127: `end` at 127, 6 is not aligned with `if` at 120, 15. [rubocop]
127: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the `/` if it should be a division. [rubocop]

== lib/jekyll/stevenson.rb (7 issues) ==
8: Unused block argument - `severity`. If it's necessary, use `_` or `_severity` as an argument name to indicate that it won't be used. [rubocop]
8: Unused block argument - `datetime`. If it's necessary, use `_` or `_datetime` as an argument name to indicate that it won't be used. [rubocop]
8: Unused block argument - `progname`. If it's necessary, use `_` or `_progname` as an argument name to indicate that it won't be used. [rubocop]
13: Unused method argument - `block`. If it's necessary, use `_` or `_block` as an argument name to indicate that it won't be used. [rubocop]
17: Use `||` instead of `or`. [rubocop]
30: Do not use `Time.now` without zone. Use one of `Time.zone.now`, `Time.now.current`, `Time.now.in_time_zone`, `Time.now.utc`, `Time.now.getlocal`, `Time.now.iso8601`, `Time.now.jisx0301`, `Time.now.rfc3339`, `Time.now.to_i`, `Time.now.to_f` instead. [rubocop]
50: Do not prefix writer method names with `set_`. [rubocop]

== lib/jekyll/tags/highlight.rb (23 issues) ==
13-40: Perceived complexity for initialize is too high. [10/7] [rubocop]
13-40: Cyclomatic complexity for initialize is too high. [9/6] [rubocop]
13-40: Assignment Branch Condition size for initialize is too high. [19.72/15] [rubocop]
16: Avoid the use of Perl-style backrefs. [rubocop]
18: Avoid the use of Perl-style backrefs. [rubocop]
18: Avoid the use of Perl-style backrefs. [rubocop]
20: Avoid the use of Perl-style backrefs. [rubocop]
24: Use 2 (not 4) spaces for indentation. [rubocop]
24: Use `delete!` instead of `gsub!`. [rubocop]
30: Use `&&` instead of `and`. [rubocop]
30: Line is too long. [127/112] [rubocop]
32: Provide an exception class and message as arguments to `raise`. [rubocop]
42-61: Assignment Branch Condition size for render is too high. [19.39/15] [rubocop]
71: Space between { and | missing. [rubocop]
77-98: Assignment Branch Condition size for render_pygments is too high. [19.05/15] [rubocop]
91: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
94: Provide an exception class and message as arguments to `raise`. [rubocop]
94: Line is too long. [119/112] [rubocop]
113: Use `tr` instead of `gsub`. [rubocop]
113: Prefer double-quoted strings inside interpolations. [rubocop]
113: Prefer double-quoted strings inside interpolations. [rubocop]
114: Redundant use of `Object#to_s` in interpolation. [rubocop]
118-119: Extra empty line detected at class body end. [rubocop]

== lib/jekyll/tags/include.rb (19 issues) ==
15-16: Extra empty line detected at class body beginning. [rubocop]
28: Do not use semicolons to terminate expressions. [rubocop]
38-56: Assignment Branch Condition size for parse_params is too high. [15.39/15] [rubocop]
42: Do not use `do` with multi-line `while`. [rubocop]
46: Use 2 (not -6) spaces for indentation. [rubocop]
47: Align `elsif` with `if`. [rubocop]
49: Align `elsif` with `if`. [rubocop]
51: `end` at 51, 10 is not aligned with `if` at 45, 18. [rubocop]
60: Use 2 (not 4) spaces for indentation. [rubocop]
60: Provide an exception class and message as arguments to `raise`. [rubocop]
76: Provide an exception class and message as arguments to `raise`. [rubocop]
106-135: Assignment Branch Condition size for render is too high. [30.25/15] [rubocop]
118: Use `&&` instead of `and`. [rubocop]
118: `Hash#has_key?` is deprecated in favor of `Hash#key?`. [rubocop]
141: `Hash#has_key?` is deprecated in favor of `Hash#key?`. [rubocop]
144: Line is too long. [116/112] [rubocop]
154: Provide an exception class and message as arguments to `raise`. [rubocop]
156: Provide an exception class and message as arguments to `raise`. [rubocop]
175: Unused method argument - `context`. If it's necessary, use `_` or `_context` as an argument name to indicate that it won't be used. You can also write as `tag_includes_dir(*)` if you want the method to accept any arguments but don't care about them. [rubocop]

== lib/jekyll/tags/post_url.rb (9 issues) ==
11: Provide an exception class and message as arguments to `raise`. [rubocop]
20-26: Assignment Branch Condition size for deprecated_equality is too high. [18.28/15] [rubocop]
51: Provide an exception class and message as arguments to `raise`. [rubocop]
59-86: Assignment Branch Condition size for render is too high. [19.13/15] [rubocop]
71: Use `next` to skip iteration. [rubocop]
73: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
74: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
75: Use `\` instead of `+` or `<<` to concatenate those strings. [rubocop]
81: Provide an exception class and message as arguments to `raise`. [rubocop]

== lib/jekyll/url.rb (1 issue) ==
14-15: Extra empty line detected at class body beginning. [rubocop]

== lib/jekyll/utils.rb (32 issues) ==
2: Use `module_function` instead of `extend self`. [rubocop]
3: Inconsistent indentation detected. [rubocop]
4: Inconsistent indentation detected. [rubocop]
7: Inconsistent indentation detected. [rubocop]
7: `%w`-literals should be delimited by `(` and `)`. [rubocop]
8: Inconsistent indentation detected. [rubocop]
9: Inconsistent indentation detected. [rubocop]
10: Inconsistent indentation detected. [rubocop]
15-17: Inconsistent indentation detected. [rubocop]
28-43: Assignment Branch Condition size for deep_merge_hashes! is too high. [15.3/15] [rubocop]
28-43: Inconsistent indentation detected. [rubocop]
30: Use `&&` instead of `and`. [rubocop]
53-57: Inconsistent indentation detected. [rubocop]
59-61: Inconsistent indentation detected. [rubocop]
60: Don't use parentheses around the condition of an `if`. [rubocop]
63-73: Inconsistent indentation detected. [rubocop]
75-81: Inconsistent indentation detected. [rubocop]
88-90: Inconsistent indentation detected. [rubocop]
97-99: Inconsistent indentation detected. [rubocop]
108-112: Inconsistent indentation detected. [rubocop]
109: Do not use `Time.localtime` without offset or zone. [rubocop]
111: Provide an exception class and message as arguments to `raise`. [rubocop]
117-119: Inconsistent indentation detected. [rubocop]
117: Rename `has_yaml_header?` to `yaml_header?`. [rubocop]
153-180: Cyclomatic complexity for slugify is too high. [8/6] [rubocop]
153-180: Inconsistent indentation detected. [rubocop]
163: Indent `when` as deep as `case`. [rubocop]
165: Indent `when` as deep as `case`. [rubocop]
167: Indent `when` as deep as `case`. [rubocop]
173: Place the . on the next line, together with the method name. [rubocop]
175: Place the . on the next line, together with the method name. [rubocop]
209-220: Inconsistent indentation detected. [rubocop]

== lib/jekyll/utils/ansi.rb (2 issues) ==
8: Use `module_function` instead of `extend self`. [rubocop]
36: Trailing whitespace detected. [rubocop]

== lib/jekyll/utils/platforms.rb (3 issues) ==
4: Use `module_function` instead of `extend self`. [rubocop]
21: Align the elements of a hash literal if they span more than one line. [rubocop]
22-23: Extra empty line detected at block body beginning. [rubocop]

Analysis complete! Found 567 issues.

@envygeeks
Copy link
Contributor

/cc @jekyll/core if you have any questions let me know.

@envygeeks envygeeks added this to the 3.1 milestone Dec 4, 2015
@envygeeks envygeeks self-assigned this Dec 4, 2015
@envygeeks
Copy link
Contributor

Here are the basics of what it enforces right now from what I've seen our source do:

  • %W, %w must use () not {} or anything else.
  • %r should use !! not {} unless you need to use {} for readability.
  • Hashes should be Hash Rockets for uniformity and clarity between keywords and hashes.
  • Max line length of 112, in my testing with both large and small fonts, this was a good compromise.
  • I would prefer us to enforce "" but right now it allows you to do whatever you please.
  • Max class size of 240 lines (this is arbitrary.)

It disables:

  • Space inside of brackets @hash[ "val"] sometimes I like to align if one after another.
  • Braces around hash paramaters method({ :key => :val }) because it's just arbitrarily bad IMNSHO.
  • Empty line around access modifiers \nprivate\ndef because that's max arbitrary.
  • Empty lines around modules body, it leads to false positives in first method comments.
  • Format parameter mismatch because it think "%c" % 27 is mismatched...
  • Useless access modifier because some people are explicit, I put private before _ALL_ privates.
  • The requirement to use fail instead of raise, because I am _raising to your attention an error_

@envygeeks
Copy link
Contributor

All of this is implicit, not explicit, a user need not worry about this though we can reference it if we need, no tests will fail if none of these pass, this is done outside of Jekyll, it does however affect our code quality, in that it will bring down CodeClimates score in the background if we don't enforce our own standards. So I'm raising to @jekyll/core and @jekyll/owners we come up with a policy and start cleaning up the source.

@parkr
Copy link
Member

parkr commented Dec 4, 2015

Initial analysis:

Daaaaaaamn that's a lot of inconsistencies.

Braces around hash paramaters method({ :key => :val }) because it's just arbitrarily bad IMNSHO.

Just curious – why?

The requirement to use fail instead of raise, because I am raising to your attention an error

"In Ruby, fail is synonymous with raise." How is fail different? I wasn't able to find a difference.

Rubocop/Style/SpaceAroundOperators: { enabled: false } # ?? looks nicer, sorry.
Rubocop/Style/AlignParameters: { enabled: false } # Because I prefer 2s/4s.
Rubocop/Style/SignalException: { enabled: false } # I prefer raising.
Rubocop/Style/Documentation: { enabled: false } # What the hell?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the comments? They're unnecessary commentary.

@parkr parkr added the pending-feedback We are waiting for more info. label Dec 4, 2015
@envygeeks
Copy link
Contributor

@parkr:

Just curious – why?

Mostly because it does not hurt performance at all, and for me I like to include them because it just feels right when I split a hash across multiple lines, when it's on a single line I never include {} but once I go across multiple lines I always include {} I like to be explicit. I should have probably mentioned that in my comment of why I disabled it.

"In Ruby, fail is synonymous with raise." How is fail different? I wasn't able to find a difference.

There isn't a difference, it's a semantics issue. I feel like I'm raising to your attention a problem, they feel like they are failing because of a problem. I feel that I am not intentionally failing, it was an accident I failed so I am raising to your attention that failure.

Github's style guide (the style guide I tend to stand with most of the time) removes that entire bit and excludes it, and like them in my own source I use raise but I am neutral to anothers source on the subject, so for example if you decide to use fail, I'll say nothing and I'll use raise myself. It's all relative semantics.

@envygeeks envygeeks force-pushed the pull/enable-codeclimate-platform branch from 3d4e1c5 to b6de905 Compare December 4, 2015 17:42
@parkr
Copy link
Member

parkr commented Dec 4, 2015

@envygeeks 👍

envygeeks added a commit that referenced this pull request Dec 4, 2015
@envygeeks envygeeks merged commit 28c5683 into master Dec 4, 2015
@envygeeks envygeeks deleted the pull/enable-codeclimate-platform branch December 4, 2015 18:08
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age pending-feedback We are waiting for more info.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CodeClimate platform.
3 participants