New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #4219: Add CodeClimate Platform. #4220
Conversation
Initial analysis:
|
/cc @jekyll/core if you have any questions let me know. |
Here are the basics of what it enforces right now from what I've seen our source do:
It disables:
|
All of this is implicit, not explicit, a user need not worry about this though we can reference it if we need, no tests will fail if none of these pass, this is done outside of Jekyll, it does however affect our code quality, in that it will bring down CodeClimates score in the background if we don't enforce our own standards. So I'm raising to @jekyll/core and @jekyll/owners we come up with a policy and start cleaning up the source. |
Daaaaaaamn that's a lot of inconsistencies.
Just curious – why?
"In Ruby, fail is synonymous with raise." How is |
Rubocop/Style/SpaceAroundOperators: { enabled: false } # ?? looks nicer, sorry. | ||
Rubocop/Style/AlignParameters: { enabled: false } # Because I prefer 2s/4s. | ||
Rubocop/Style/SignalException: { enabled: false } # I prefer raising. | ||
Rubocop/Style/Documentation: { enabled: false } # What the hell? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the comments? They're unnecessary commentary.
Mostly because it does not hurt performance at all, and for me I like to include them because it just feels right when I split a hash across multiple lines, when it's on a single line I never include
There isn't a difference, it's a semantics issue. I feel like I'm raising to your attention a problem, they feel like they are failing because of a problem. I feel that I am not intentionally failing, it was an accident I failed so I am raising to your attention that failure. Github's style guide (the style guide I tend to stand with most of the time) removes that entire bit and excludes it, and like them in my own source I use raise but I am neutral to anothers source on the subject, so for example if you decide to use fail, I'll say nothing and I'll use raise myself. It's all relative semantics. |
3d4e1c5
to
b6de905
Compare
Fix: #4219: Add CodeClimate Platform.
PR automatically created for @envygeeks.
Fix: #4219: Add CodeClimate Platform.