Include tag should accept multiple variables in the include name #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with this change. |
|
Yeah, because the as is already documented we still have some work to do on our Liquid processing which is slightly more powerful but has a few quirks so the pull for my larger refactor of our tags to make every tag in (including user tags) easier won't land until jekyll-assets stabilizes it's liquid processing on tag arguments. |
|
I vote |
because it could be 3.2 3.3 before that refactor even lands.
parkr
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm playing around Ruby regex these days and happen to see #4028 , this PR gives it a quick fix.
@envygeeks might have a big refactor of Jekyll own tags referring to what he mentioned in #4028 , so it's ok if this doesn't get merged.