This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
replace single filter with multiple filters #1853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-gu
force-pushed
the
api_filter
branch
2 times, most recently
from
December 9, 2015 02:05
33a9ae1
to
7461247
Compare
maybe I just go and implement a simple stringset instead. |
|
||
package set | ||
|
||
type String map[string]struct{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imagine if we had generics...
Looks like some of the tests may have gotten tripped up by the switch to
Other than that, LGTM. |
@dgonyeo thanks, will fix the tests :) |
Will need a rebase after #1786 |
yifan-gu
force-pushed
the
api_filter
branch
2 times, most recently
from
December 14, 2015 19:50
aaddb5a
to
96d78df
Compare
Rebased. |
ping @dgonyeo ? |
LGTM |
yifan-gu
added a commit
that referenced
this pull request
Dec 16, 2015
replace single filter with multiple filters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a break change for API service:
1, replaces the single filter field with multiple filters in
ListPods
andListImages
.2, filters are combined with
OR
, and conditions within a filter are combined withAND
, which provides a better flexibility.cc @dgonyeo