build: Allow packagers to override stage1 version #1821
Conversation
@@ -154,6 +160,15 @@ AS_CASE([${RKT_STAGE1_SETUP_KIND}], | |||
RKT_STAGE1_DEFAULT_VERSION=''], | |||
[AC_MSG_ERROR([*** Unknown setup kind, should not happen])]) | |||
|
|||
## Stage1 flavor version override verfication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/verfication/verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bah, thanks for spotting.
@krnowak Thanks! Can you explain in |
I suppose I will have to simply write a separate document about configure flags and their uses and link to it from the other places that mention configure script or its parameters. |
@alban: ^ |
@krnowak good idea. As long as |
0814036
to
2fde56a
Compare
Depends on #1824 for documentation fixes. |
2fde56a
to
1ed56ec
Compare
8e3d9ef
to
b5355aa
Compare
Rebased. |
|
||
This parameter takes a comma-separated list of all the flavors that the build system should assemble. | ||
Depending on a default stage1 image setup, this list is by default either empty or set to `coreos,kvm` for, respectively, detailed setup and flavor setup. | ||
Note that specifying this parameter does not necessarily means that rkt will use them in the end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/means/mean/
#### `--with-stage1-default-location` | ||
|
||
This parameter tells rkt where to find the default stage1 image if it is not found in the store. | ||
For the detailed setup, the default value of this parameter is empty, so if it is not provided, you may be forced to inform rkt about the location of stage1 image at runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about the location of the stage1 image
This flag overrides the version used in built stage1 image manifests. Also, when using --with-stage1-default-flavor, the new flag changes the default stage1 version to the overridden one, so rkt will search in the store for an image with the standard coreos name and with an overridden version. This flag is useful for distros serving updated revisions of rkt, like for example in Debian, they might want to put a version 0.12.0-2.
b5355aa
to
55ad3b8
Compare
Khem, I thought it was merged... Anyway, I updated this branch some time ago. |
LGTM |
build: Allow packagers to override stage1 version
Fixes #1813.