This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
config: Make the data directory configurable #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to postpone renaming the |
|
TBD: Update the CHANGELOG, after the 0.12.0 is released. |
krnowak
force-pushed
the
krnowak/data-dir
branch
from
5421e8b
to
772634a
Compare
|
Just a nitpick |
| @@ -28,4 +28,3 @@ the CAS. | |||
|
|
|||
| The [configuration](https://github.com/coreos/rkt/blob/master/Documentation/configuration.md) | |||
| on-disk format is documented separately. | |||
|
|
|||
There was a problem hiding this comment.
Actually the first sentence in this file is:
The data directory is normally /var/lib/rkt but rkt can be requested to use another directory via the --dir command line argument.
Can this updated? Maybe something like:
The data directory is normally /var/lib/rkt, unless configured otherwise. + link to configuration.md
krnowak
force-pushed
the
krnowak/data-dir
branch
from
772634a
to
97407b4
Compare
|
Rebased to master and updated the documentation. |
krnowak
force-pushed
the
krnowak/data-dir
branch
2 times, most recently
from
678d14a
to
46807a6
Compare
|
needs to be rebased again. |
Adds a new category of config called "paths" which is intended to allow the user to configure various paths. At the moment, it supports one - the data directory. By setting this, you can control where image files are stored without having to give a CLI argument.
krnowak
force-pushed
the
krnowak/data-dir
branch
from
46807a6
to
6db3861
Compare
|
Rebased. |
|
LGTM |
alban
added a commit
that referenced
this pull request
Dec 7, 2015
config: Make the data directory configurable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new category of config called "paths" which is intended to
allow the user to configure various paths. At the moment, it supports
one - the data directory. By setting this, you can control where image
files are stored without having to give a CLI argument.
This is based on #1192.
I will need it for configuring default stage1 directory.